Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vectorized hash grouping on one column #7316

Draft
wants to merge 49 commits into
base: main
Choose a base branch
from
Draft

Conversation

akuzm
Copy link
Member

@akuzm akuzm commented Oct 2, 2024

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 89.94709% with 57 lines in your changes missing coverage. Please review.

Project coverage is 82.59%. Comparing base (59f50f2) to head (4c71b9c).
Report is 548 commits behind head on main.

Files with missing lines Patch % Lines
tsl/src/import/ts_simplehash.h 83.21% 10 Missing and 14 partials ⚠️
tsl/src/nodes/vector_agg/grouping_policy_hash.c 90.18% 2 Missing and 14 partials ⚠️
tsl/src/nodes/vector_agg/hash_single_text.c 80.64% 3 Missing and 3 partials ⚠️
...l/src/nodes/vector_agg/hash_table_functions_impl.c 88.46% 2 Missing and 4 partials ⚠️
tsl/src/nodes/vector_agg/plan.c 71.42% 0 Missing and 4 partials ⚠️
tsl/src/nodes/vector_agg/single_fixed_key_impl.c 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7316      +/-   ##
==========================================
+ Coverage   80.06%   82.59%   +2.52%     
==========================================
  Files         190      236      +46     
  Lines       37181    43172    +5991     
  Branches     9450    10826    +1376     
==========================================
+ Hits        29770    35658    +5888     
- Misses       2997     3199     +202     
+ Partials     4414     4315      -99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant