Disable autovacuum on compressed hypercore chunk #7358
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkindahl
force-pushed
the
hypercore-disable-compressed-vacuum
branch
from
401a8b5
to
eeabdec
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7358 +/- ##
==========================================
+ Coverage 80.06% 82.59% +2.53%
==========================================
Files 190 229 +39
Lines 37181 42709 +5528
Branches 9450 10725 +1275
==========================================
+ Hits 29770 35277 +5507
- Misses 2997 3156 +159
+ Partials 4414 4276 -138 ☔ View full report in Codecov by Sentry. |
mkindahl
force-pushed
the
hypercore-disable-compressed-vacuum
branch
2 times, most recently
from
d898b7a
to
b8ade07
Compare
Autovacuum will run on all relations that are not explicitly disabled, which can lead to unnecessarily vacuuming the compressed relation twice: once as part of the hypercore table access method and once as a separate relation. This commit disables `autovacuum_enabled` for the compressed chunks when the main chunk is turned into a hypercore chunk. It deals with both the cases that you have a partially compressed chunk.
mkindahl
force-pushed
the
hypercore-disable-compressed-vacuum
branch
from
b8ade07
to
df61898
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autovacuum will run on all relations that are not explicitly disabled,
which can lead to unnecessarily vacuuming the compressed relation
twice: once as part of the hypercore table access method and once as a
separate relation.
This commit disables
autovacuum_enabledfor the compressed chunkswhen the main chunk is turned into a hypercore chunk. It deals with
both the cases that you have a partially compressed chunk.
Disable-check: commit-count