[IMP] web,*: remove unused .o-dropdown-menu class

task-3439226 Part-of: odoo#133289
timimsms · Aug 31, 2023 · 8bbe704 · 8bbe704
1 parent d629aa0
commit 8bbe704
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 24 deletions.
diff --git a/addons/analytic/static/src/components/analytic_distribution/analytic_distribution.xml b/addons/analytic/static/src/components/analytic_distribution/analytic_distribution.xml
@@ -13,7 +13,7 @@
     </t>
 
     <t t-name="analytic.AnalyticDistributionPopup">
-        <div class="analytic_distribution_popup o-dropdown-menu show rounded py-0" t-if="state.showDropdown" t-ref="analyticDropdown">
+        <div class="analytic_distribution_popup dropdown-menu o-dropdown--menu show rounded py-0" t-if="state.showDropdown" t-ref="analyticDropdown">
             <div class="popover-header sticky-top">
                 <div class="d-flex">
                     <div class="h5 mt-2 me-auto">Analytic</div>

diff --git a/addons/test_mail/static/tests/systray_activity_menu_tests.js b/addons/test_mail/static/tests/systray_activity_menu_tests.js
@@ -163,7 +163,7 @@ QUnit.test("activity menu widget: activity view icon", async (assert) => {
         },
     });
     await click(".o-mail-ActivityGroup:contains('mail.test.activity') button[title='Summary']");
-    await contains(".o-dropdown-menu", 0);
+    await contains(".dropdown-menu", 0);
     await click(".o_menu_systray i[aria-label='Activities']");
     await click(".o-mail-ActivityGroup:contains('res.partner') button[title='Summary']");
     assert.verifySteps(["do_action:mail.test.activity", "do_action:res.partner"]);

diff --git a/addons/web/static/src/legacy/scss/dropdown.scss b/addons/web/static/src/legacy/scss/dropdown.scss
@@ -58,10 +58,6 @@
     }
 }
 
-.o-dropdown-menu {
-    @extend .dropdown-menu;
-}
-
 // = Legacy submenus
 
 // TODO probably remove those next rules that target dropdown main classes once

diff --git a/addons/web/static/src/webclient/webclient.scss b/addons/web/static/src/webclient/webclient.scss
@@ -58,19 +58,6 @@ kbd {
   line-height: 1.1;
 }
 
-// Set position of our custom o-dropdown-menu (not bootstrap)
-.o-dropdown-menu {
-  top: 100%;
-  &.dropdown-menu-start {
-    left: 0;
-    right: auto;
-  }
-  &.dropdown-menu-end {
-    left: auto;
-    right: 0;
-  }
-}
-
 // == Boostrap Dropdown
 // ----------------------------------------------------------------------------
 .dropdown-menu {

diff --git a/addons/web_editor/static/src/scss/wysiwyg.scss b/addons/web_editor/static/src/scss/wysiwyg.scss
@@ -217,11 +217,6 @@ $o-we-zindex: $o-we-overlay-zindex + 1 !default;
             background: var(--o-we-toolbar-border, #{$o-we-toolbar-border});
             transform: scaleY(.6)
         }
-
-        // Adjust dropdown-menu position, but not when already handled in js
-        .o-dropdown-menu:not([x-placement]) {
-            margin-left: $o-we-toolbar-entries-gap;
-        }
     }
 
     // Main layout of buttons