Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lexical dependency is unsound #4

Open
ivan770 opened this issue Aug 6, 2024 · 2 comments · May be fixed by #6
Open

lexical dependency is unsound #4

ivan770 opened this issue Aug 6, 2024 · 2 comments · May be fixed by #6

Comments

@ivan770
Copy link

ivan770 commented Aug 6, 2024

Hi.

json-number has a dependency on lexical, which contains multiple soundness issues within its implementation. Dependabot mentions that libcore already integrated the updated float parsing algorithm, making it possible to remove the dependency entirely.
@timothee-haudebourg
Copy link
Owner

Thank you for raising this issue. I'm not using lexical to parse numbers, but to format them according to JCS rules. I'll have to find an alternative before I can get rid of it.

flavio added a commit to flavio/json-number that referenced this issue Sep 18, 2024
@flavio
chore(deps): update lexical dependency
0df79bf 
Update to latest version of lexical crate, this is required to address
the following security advisories:

- lexical: RUSTSEC-2023-0055
- lexical-core (a transitive dependency of lexical): RUSTSEC-2023-0086

This fixes timothee-haudebourg#4

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
@flavio flavio linked a pull request Sep 18, 2024 that will close this issue
Open
@flavio
Copy link

flavio commented Sep 18, 2024

@timothee-haudebourg no need to find an alternative, there's an update that addresses the security issues. See the PR linked above 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(deps): update lexical dependency flavio/json-number
3 participants
@flavio @ivan770 @timothee-haudebourg