[pull] master from sporkmonger:master #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This option removes empty parameters, having no name or value
When the protocol is missing, PublicSuffix returns nil:
Addressable::URI.parse("www.example.co.uk").domain # => nil
Fixed documentation by adding protocol to the examples:
Addressable::URI.parse("http://www.example.co.uk").domain # => "example.co.uk"
* sudo is required to install / update apt-get packages. * `idn-ruby` gem requires the GNU IDN library to be installed. `apt-get` package `libidn11-dev` provides the necessary components * Bundler versions supported across various Ruby installations are inconsistent and hence cannot be reliably updated. So prefer using pre-installed Bundler versions. * JRuby builds have an increased tendency to fail due to rvm issues and incompatibility with pre-installed Bundler versions.
Fix failing Travis builds
Update public suffix gem
Add :compacted option to URI#normalized_query
Iterate with #each to reduce array allocations
[Docs] Add protocol to docs for methods that use PublicSuffix
Use host when setting TLD
fixes #263 Be able to use #heuristic_parse for mailto URLs
Reduce object allocations in URI.encode_component and URI.normalize_component
Test against TruffleRuby
Remove changelog reference to unmerged pull request
add ruby 2.7 to ci process
See oracle/truffleruby#1857 Also specify the version we test against, instead of having it change unexpectedly.
JRuby 9.1.17.0 and 9.2.6.0 failed on bundle install when they used Bundler 2.1.2.[1][2] Last green build[3] used Bundler 2.0.2. JRuby 9.2.7.0 and up works with Bundler 2.1.x[4]. Did not manage to remove Bundler 2.1.4 from Travis with just one "gem uninstall ..." command, don't know why. 1: https://travis-ci.org/sporkmonger/addressable/jobs/629762474 2: https://travis-ci.org/sporkmonger/addressable/jobs/629762473 3: https://travis-ci.org/sporkmonger/addressable/builds/583018677 4: https://travis-ci.org/dentarg/addressable/builds/633344956
Fix CI failures
Test against TruffleRuby 19.3.1
Test the latest TruffleRuby release
Since simplecov needs a fix which is not in TruffleRuby 20.0.0, see #384
Test with truffleruby-head
…mat_error Surround invalid scheme with quotes to make error message more readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )