Use trustedProxies values as arrays #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobweinstock
requested changes
Jan 24, 2023
| @@ -33,7 +33,7 @@ spec: | |||
| {{- end }} | |||
| env: | |||
| - name: HEGEL_TRUSTED_PROXIES | |||
| value: {{ required "missing trustedProxies" .Values.trustedProxies | quote }} | |||
| value: {{ join "," .Values.trustedProxies }} | |||
There was a problem hiding this comment.
Suggested change
| value: {{ join "," .Values.trustedProxies }} | |
| value: {{ required "missing trustedProxies" (join "," .Values.trustedProxies | quote) }} |
| @@ -37,7 +37,7 @@ spec: | |||
| {{- end }} | |||
| env: | |||
| - name: TRUSTED_PROXIES | |||
| value: {{ required "missing trustedProxies" .Values.trustedProxies | quote }} | |||
| value: {{ join "," .Values.trustedProxies }} | |||
There was a problem hiding this comment.
Suggested change
| value: {{ join "," .Values.trustedProxies }} | |
| value: {{ required "missing trustedProxies" (join "," .Values.trustedProxies | quote) }} |
|
Closing in favor of a holistic refactor in #32 that will address the underlying issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses array instead of string to manage trustedProxies.
Why is this needed
Fixes: #29
How Has This Been Tested?
I managed to deploy the services using the charts without error. A comma-separated list of proxies appears using
kubectl get pods -o yaml -n tink-system <pod-name>How are existing users impacted? What migration steps/scripts do we need?
N.A.
Checklist:
I have: