Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a list for Hegel trusted proxy configuration #34

Merged
merged 1 commit into from
Feb 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tinkerbell/hegel/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ spec:
{{- end }}
env:
- name: HEGEL_TRUSTED_PROXIES
value: {{ required "missing trustedProxies" .Values.trustedProxies | quote }}
value: {{ required "missing trustedProxies" ( join "," .Values.trustedProxies | quote ) }}
{{- range $i, $env := .Values.env }}
- name: {{ $env.name | quote }}
value: {{ $env.value | quote }}
Expand Down
5 changes: 4 additions & 1 deletion tinkerbell/hegel/values.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
deploy: true
trustedProxies: ""
name: hegel
image: quay.io/tinkerbell/hegel:v0.10.1
imagePullPolicy: IfNotPresent
Expand All @@ -18,3 +17,7 @@ resources:
memory: 64Mi
roleName: hegel-role
roleBindingName: hegel-rolebinding

# Trusted proxies defines a list of IP or CIDR ranges that are allowed to set the X-Forwarded-For
# header. This typically requires all Pod CIDRs in the cluster.
trustedProxies: []