Use checksum from Hook release: #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hook now provides a checksum file. Use it to verify downloads of Hook. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
| wget "$f" | ||
| done | ||
| sha512sum -c checksum.txt | ||
| for f in *.tar.gz; do tar --no-same-permissions --overwrite -ozxvf "$f" && rm -f "$f"; done |
There was a problem hiding this comment.
Are we confident files aren't going to overwrite each other from the double untar? What about future changes? Would it be safer to use a subdirectory?
There was a problem hiding this comment.
by double tar, do you mean the 2 iterations in the for loop? If so, there shouldnt be a concern. The vmlinuz and initramfs for each arch (x86_64 and arm) are named differently.
Sorry, i dont know if i follow what a subdirectory provides us?
There was a problem hiding this comment.
are you saying download to a temp dir and extract to the final location instead of downloading to the final dir?
There was a problem hiding this comment.
hmm...regardless. I'll download to a tmp directory.
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
chrisdoherty4
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hook now provides a checksum file. Use it to verify downloads of Hook.
Why is this needed
Fixes: #
How Has This Been Tested?
Manually tested.
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: