Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rufio CRDs: #74

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Conversation

jacobweinstock
Copy link
Member

Description

The CRD for Rufio were not updated to match the Rufio version. Even though the stack chart itself didn't change, we only create an OCI image for the stack chart. So this update to the Rufio chart necessitates a stack chart version bump.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

The CRD for Rufio were not updated to match the Rufio version.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Even though the stack chart itself didn't change,
we only create an OCI image for the stack chart.
So this update to the Rufio chart necessitates a stack
chart version bump.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Copy link
Member

@chrisdoherty4 chrisdoherty4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we could develop a tool at some point that leverages the CRDs in the various repositories to avoid the duplication here.

@jacobweinstock jacobweinstock added the ready-to-merge Mergify: Ready for Merging label Nov 2, 2023
@mergify mergify bot merged commit a38d766 into tinkerbell:main Nov 2, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Mergify: Ready for Merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants