Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the changes between two commits more explicit #92

Merged
merged 2 commits into from
Jun 9, 2021

Conversation

monoxgas
Copy link
Contributor

@monoxgas monoxgas commented Jun 9, 2021

The current strategy for git diff can fail to be accurate in cases where local files are modified as part of the checkout. A common case is changes made to line endings.

I've made a small change to track an explicit PREV_SHA against a CURR_SHA (HEAD by default). This will ensure file changes accurately reflect only those changes that actually occurred as part of the commit history.

entrypoint.sh Outdated Show resolved Hide resolved
@jackton1 jackton1 merged commit f32b39d into tj-actions:main Jun 9, 2021
@jackton1
Copy link
Member

jackton1 commented Jun 9, 2021

Thanks @monoxgas

@jackton1
Copy link
Member

jackton1 commented Jun 9, 2021

@all-contributors please add @monoxgas for code

@jackton1
Copy link
Member

jackton1 commented Jun 9, 2021

@all-contributors please add @monoxgas for code

@allcontributors
Copy link
Contributor

@jackton1

I've put up a pull request to add @monoxgas! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants