Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getOptionValue and setOptionValue #1521

Merged
merged 7 commits into from
May 18, 2021
Merged

Add getOptionValue and setOptionValue #1521

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ad30296
Simplify typings by removing default export of program
shadowspawn May 15, 2021
8cb926c
Switch any to unknown per lint suggestion
shadowspawn May 15, 2021
01143de
Add typings change to deprecated.md
shadowspawn May 16, 2021
7d9e1df
Make getOptionValue and setOptionValue public
shadowspawn May 16, 2021
1e60fb3
Merge branch 'release/8.x' into feature/access-option-values
shadowspawn May 17, 2021
4bacf3a
Fix comment change lost in merge
shadowspawn May 17, 2021
d4697f6
Tweak wording
shadowspawn May 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'release/8.x' into feature/access-option-values
  • Loading branch information
@shadowspawn
shadowspawn committed May 17, 2021
commit 1e60fb383cb0a8a2ad0db9c8a32f831825ad8d19
1 change: 0 additions & 1 deletion typings/index.test-d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ const program: commander.Command = new commander.Command();
program.silly; // <-- Error, hurrah!

// Check for exported global Command object(s)
// expectAssignable<commander.Command>(commander); // legacy default export of program
expectType<commander.Command>(commander.program);

// Check export classes and functions exist
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.