Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix React deprecation warning in test #306

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Fix React deprecation warning in test #306

merged 1 commit into from
Mar 19, 2018

Conversation

TheDancingCode
Copy link
Contributor

React emitted this deprecation warning while running the tests:

Warning: Accessing createClass via the main React package is deprecated, and will be removed in React v16.0. Use a plain JavaScript class instead. If you're not yet ready to migrate, create-react-class v15.* is available on npm as a temporary, drop-in replacement. For more info see https://fb.me/react-create-class

I replaced React.createClass with a plain javascript class in the fixture to future-proof your tests.

Replacing React.createClass with a plain javascript class in fixture.
@doowb
Copy link
Collaborator

doowb commented Mar 16, 2018

Thanks @TheDancingCode!

I'll review this weekend.

@doowb doowb self-assigned this Mar 16, 2018
@doowb doowb merged commit 4e05c88 into tj:master Mar 19, 2018
@TheDancingCode TheDancingCode deleted the react-fixture branch March 20, 2018 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants