Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GOG game detection fails for a game with an overlay #291

Closed
hogarthj opened this issue Jul 29, 2019 · 6 comments
Closed

GOG game detection fails for a game with an overlay #291

hogarthj opened this issue Jul 29, 2019 · 6 comments

Comments

@hogarthj
Copy link

Once an overlay has been enabled the gameinfo file gets moved to the base overlay and is no longer visible in the root game directory.

This affects any game with DLC or with a manual overlay, eg for a mod or similar patch.

Adding a symlink to the gameinfo appears to allow gamehub to still detect the installed game.
tkashkin added a commit that referenced this issue Jul 29, 2019
@tkashkin
Add /opt/ and /var/opt/ to FSOverlay allowed paths list (#290)
f28cc89 
Wait for overlays to mount before updating game status (#291)
@hogarthj
Copy link
Author

hogarthj commented Aug 2, 2019

Note that this doesn't appear to have quite worked as desired with the referenced commit ...

From gamehub not running and no overlay mounts existing:

[james@james-lap gamehub]$ mount -t overlay
[james@james-lap gamehub]$

Initially opening gamehub:
Screenshot from 2019-08-02 20-16-28

Mounts then take place in the background:

[james@james-lap gamehub]$ mount -t overlay
com.github.tkashkin.gamehub_overlay_7ea5b96b0fe21063b065301eab90add0 on /opt/gaming/gog/Hacknet/_gamehub/_overlay/merged type overlay (rw,relatime,seclabel,lowerdir=/opt/gaming/gog/Hacknet/_gamehub/overlays/dlc_1806938744:/opt/gaming/gog/Hacknet/_gamehub/overlays/base,upperdir=/opt/gaming/gog/Hacknet/_gamehub/_overlay/persist,workdir=/opt/gaming/gog/Hacknet/_gamehub/_overlay/workdir)
com.github.tkashkin.gamehub_overlay_074aae3fea27ed68cd8260c856fed867 on /opt/gaming/gog/Shining_Song_Starnova/_gamehub/_overlay/merged type overlay (rw,relatime,seclabel,lowerdir=/opt/gaming/gog/Shining_Song_Starnova/_gamehub/overlays/uncensor:/opt/gaming/gog/Shining_Song_Starnova/_gamehub/overlays/base,upperdir=/opt/gaming/gog/Shining_Song_Starnova/_gamehub/_overlay/persist,workdir=/opt/gaming/gog/Shining_Song_Starnova/_gamehub/_overlay/workdir)
com.github.tkashkin.gamehub_overlay_eff791ebb5d9315336ed0e6b87464f8c on /opt/gaming/gog/Sunrider_Academy/_gamehub/_overlay/merged type overlay (rw,relatime,seclabel,lowerdir=/opt/gaming/gog/Sunrider_Academy/_gamehub/overlays/uncensor:/opt/gaming/gog/Sunrider_Academy/_gamehub/overlays/base,upperdir=/opt/gaming/gog/Sunrider_Academy/_gamehub/_overlay/persist,workdir=/opt/gaming/gog/Sunrider_Academy/_gamehub/_overlay/workdir)
com.github.tkashkin.gamehub_overlay_6128a4cc79ad37082a84358492c1553b on /opt/gaming/gog/Cultist_Simulator/_gamehub/_overlay/merged type overlay (rw,relatime,seclabel,lowerdir=/opt/gaming/gog/Cultist_Simulator/_gamehub/overlays/dlc_1293681291:/opt/gaming/gog/Cultist_Simulator/_gamehub/overlays/dlc_2041502577:/opt/gaming/gog/Cultist_Simulator/_gamehub/overlays/dlc_1885030513:/opt/gaming/gog/Cultist_Simulator/_gamehub/overlays/dlc_1556868113:/opt/gaming/gog/Cultist_Simulator/_gamehub/overlays/base,upperdir=/opt/gaming/gog/Cultist_Simulator/_gamehub/_overlay/persist,workdir=/opt/gaming/gog/Cultist_Simulator/_gamehub/_overlay/workdir)
com.github.tkashkin.gamehub_overlay_182cbf5c1ff934307965f4331d00f917 on /opt/gaming/gog/Sunrider_Mask_of_Arcadius/_gamehub/_overlay/merged type overlay (rw,relatime,seclabel,lowerdir=/opt/gaming/gog/Sunrider_Mask_of_Arcadius/_gamehub/overlays/uncensor:/opt/gaming/gog/Sunrider_Mask_of_Arcadius/_gamehub/overlays/base,upperdir=/opt/gaming/gog/Sunrider_Mask_of_Arcadius/_gamehub/_overlay/persist,workdir=/opt/gaming/gog/Sunrider_Mask_of_Arcadius/_gamehub/_overlay/workdir)
com.github.tkashkin.gamehub_overlay_156c6094456c75ffa9abda6973b12e6d on /opt/gaming/gog/Sunrider_Liberation_Day__Captains_Edition/_gamehub/_overlay/merged type overlay (rw,relatime,seclabel,lowerdir=/opt/gaming/gog/Sunrider_Liberation_Day__Captains_Edition/_gamehub/overlays/uncensor:/opt/gaming/gog/Sunrider_Liberation_Day__Captains_Edition/_gamehub/overlays/base,upperdir=/opt/gaming/gog/Sunrider_Liberation_Day__Captains_Edition/_gamehub/_overlay/persist,workdir=/opt/gaming/gog/Sunrider_Liberation_Day__Captains_Edition/_gamehub/_overlay/workdir)
com.github.tkashkin.gamehub_overlay_c83de67bee45b8bb2c233a51fc6df185 on /opt/gaming/gog/War_for_the_Overworld/_gamehub/_overlay/merged type overlay (rw,relatime,seclabel,lowerdir=/opt/gaming/gog/War_for_the_Overworld/_gamehub/overlays/dlc_1710869761:/opt/gaming/gog/War_for_the_Overworld/_gamehub/overlays/dlc_1143238479:/opt/gaming/gog/War_for_the_Overworld/_gamehub/overlays/dlc_1603890758:/opt/gaming/gog/War_for_the_Overworld/_gamehub/overlays/dlc_1742747067:/opt/gaming/gog/War_for_the_Overworld/_gamehub/overlays/dlc_1571774750:/opt/gaming/gog/War_for_the_Overworld/_gamehub/overlays/dlc_1906832216:/opt/gaming/gog/War_for_the_Overworld/_gamehub/overlays/base,upperdir=/opt/gaming/gog/War_for_the_Overworld/_gamehub/_overlay/persist,workdir=/opt/gaming/gog/War_for_the_Overworld/_gamehub/_overlay/workdir)
com.github.tkashkin.gamehub_overlay_d08e1620be4018ed7992debd4d1f85f0 on /opt/gaming/gog/Hard_West/_gamehub/_overlay/merged type overlay (rw,relatime,seclabel,lowerdir=/opt/gaming/gog/Hard_West/_gamehub/overlays/dlc_1457001454:/opt/gaming/gog/Hard_West/_gamehub/overlays/base,upperdir=/opt/gaming/gog/Hard_West/_gamehub/_overlay/persist,workdir=/opt/gaming/gog/Hard_West/_gamehub/_overlay/workdir)
com.github.tkashkin.gamehub_overlay_8536545dbaa79c74518715c91f6f9086 on /opt/gaming/gog/HuniePop/_gamehub/_overlay/merged type overlay (rw,relatime,seclabel,lowerdir=/opt/gaming/gog/HuniePop/_gamehub/overlays/uncensor:/opt/gaming/gog/HuniePop/_gamehub/overlays/base,upperdir=/opt/gaming/gog/HuniePop/_gamehub/_overlay/persist,workdir=/opt/gaming/gog/HuniePop/_gamehub/_overlay/workdir)
com.github.tkashkin.gamehub_overlay_bd86c9f960b5e5863395aa3e1400e637 on /opt/gaming/gog/Holy_Potatoes_A_Weapon_Shop/_gamehub/_overlay/merged type overlay (rw,relatime,seclabel,lowerdir=/opt/gaming/gog/Holy_Potatoes_A_Weapon_Shop/_gamehub/overlays/dlc_1653722207:/opt/gaming/gog/Holy_Potatoes_A_Weapon_Shop/_gamehub/overlays/base,upperdir=/opt/gaming/gog/Holy_Potatoes_A_Weapon_Shop/_gamehub/_overlay/persist,workdir=/opt/gaming/gog/Holy_Potatoes_A_Weapon_Shop/_gamehub/_overlay/workdir)
com.github.tkashkin.gamehub_overlay_b3427e089b82978b086d923cb0c509ff on /opt/gaming/gog/Monster_Prom/_gamehub/_overlay/merged type overlay (rw,relatime,seclabel,lowerdir=/opt/gaming/gog/Monster_Prom/_gamehub/overlays/dlc_1879783677:/opt/gaming/gog/Monster_Prom/_gamehub/overlays/base,upperdir=/opt/gaming/gog/Monster_Prom/_gamehub/_overlay/persist,workdir=/opt/gaming/gog/Monster_Prom/_gamehub/_overlay/workdir)
com.github.tkashkin.gamehub_overlay_d94826426648a49481e400919d68a65b on /opt/gaming/gog/Renowned_Explorers_International_Society/_gamehub/_overlay/merged type overlay (rw,relatime,seclabel,lowerdir=/opt/gaming/gog/Renowned_Explorers_International_Society/_gamehub/overlays/dlc_1992524817:/opt/gaming/gog/Renowned_Explorers_International_Society/_gamehub/overlays/dlc_1460114368:/opt/gaming/gog/Renowned_Explorers_International_Society/_gamehub/overlays/base,upperdir=/opt/gaming/gog/Renowned_Explorers_International_Society/_gamehub/_overlay/persist,workdir=/opt/gaming/gog/Renowned_Explorers_International_Society/_gamehub/_overlay/workdir)
[james@james-lap gamehub]$

Closing and then re-opening gamehub then detects the games that have just been mounted:
Screenshot from 2019-08-02 20-18-21

Built from current head with the current fedora spec:

[james@james-lap gamehub]$ com.github.tkashkin.gamehub
[INFO]   - GameHub
[INFO]       Version: 0.14.2-9b022f2-dev
[INFO]       Branch:  dev
[INFO]       Commit:  9b022f299b874024f67030ac187559085efd1d43
[INFO]   - Environment
[INFO]       Distro:  Fedora release 30 (Thirty)
[INFO]       DE:      GNOME
[INFO]       GTK:     3.24.10
[INFO]       Themes:  Adwaita | Adwaita

tkashkin added a commit that referenced this issue Aug 2, 2019
@tkashkin
Fix overlays detection (#291)
6498058
@tkashkin
Copy link
Owner

tkashkin commented Aug 2, 2019

@hogarthj I think it should be fixed in 6498058.

@hogarthj
Copy link
Author

hogarthj commented Aug 2, 2019

Just built the current dev snapshot and confirm that it fixes this issue.

@tkashkin tkashkin closed this as completed Aug 2, 2019
@hogarthj
Copy link
Author

hogarthj commented Aug 2, 2019

Actually scratch that ... things are more broken than before ... on further testing it's autodetecting/hard-coding/etc the wrong path to run with @tkashkin ...

Monster Prom for example ... as seen in this screenshot it has DLC overlay ...
Screenshot from 2019-08-02 23-04-08

Looking at the properties the start.sh path is to the base overlay directory, and not the merge directory.
Screenshot from 2019-08-02 23-04-49

If I manually set it back to the merged directory:
Screenshot from 2019-08-02 23-05-48

Closing the properties window has it going back to the base version as soon as I close it ...

It's literally not possible to open the game with DLC with this build - going back to the previous snapshot as at least that just required opening gamehub, closing gamehub, an dthen opening it again for it to work as expected.

@tkashkin tkashkin reopened this Aug 2, 2019
tkashkin added a commit that referenced this issue Aug 4, 2019
@tkashkin
Fix Game.get_file() (#291)
eecf1db
@tkashkin
Copy link
Owner

tkashkin commented Aug 4, 2019

Does it work in eecf1db?

@hogarthj
Copy link
Author

hogarthj commented Aug 5, 2019

Confirming it works on the current dev snapshot - thanks :)

@tkashkin tkashkin closed this as completed Aug 5, 2019
hagabaka pushed a commit to hagabaka/GameHub that referenced this issue Aug 23, 2019
@tkashkin @hagabaka
Add /opt/ and /var/opt/ to FSOverlay allowed paths list (tkashkin…
94ff468 
…#290)

Wait for overlays to mount before updating game status (tkashkin#291)
hagabaka pushed a commit to hagabaka/GameHub that referenced this issue Aug 23, 2019
@tkashkin @hagabaka
Fix overlays detection (tkashkin#291)
ddfc9e1
hagabaka pushed a commit to hagabaka/GameHub that referenced this issue Aug 23, 2019
@tkashkin @hagabaka
Fix Game.get_file() (tkashkin#291)
18bc9f0
Lucki pushed a commit to Lucki/GameHub that referenced this issue Oct 30, 2021
@tkashkin
Add /opt/ and /var/opt/ to FSOverlay allowed paths list (tkashkin…
68500c3 
…#290)

Wait for overlays to mount before updating game status (tkashkin#291)


Former-commit-id: f28cc89
Lucki pushed a commit to Lucki/GameHub that referenced this issue Oct 30, 2021
@tkashkin
Fix overlays detection (tkashkin#291)
19dc731 
Former-commit-id: 6498058
Lucki pushed a commit to Lucki/GameHub that referenced this issue Oct 30, 2021
@tkashkin
Fix Game.get_file() (tkashkin#291)
0310a8c 
Former-commit-id: eecf1db
Lucki pushed a commit to Lucki/GameHub that referenced this issue Oct 30, 2021
@tkashkin @hagabaka
Add /opt/ and /var/opt/ to FSOverlay allowed paths list (tkashkin…
6187564 
…#290)

Wait for overlays to mount before updating game status (tkashkin#291)


Former-commit-id: 94ff468
Lucki pushed a commit to Lucki/GameHub that referenced this issue Oct 30, 2021
@tkashkin @hagabaka
Fix overlays detection (tkashkin#291)
4ee9adf 
Former-commit-id: ddfc9e1
Lucki pushed a commit to Lucki/GameHub that referenced this issue Oct 30, 2021
@tkashkin @hagabaka
Fix Game.get_file() (tkashkin#291)
506ef92 
Former-commit-id: 18bc9f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tkashkin @hogarthj