Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder variables are not working correctly #632

Closed
Franz-Heinz opened this issue May 13, 2022 · 3 comments
Closed

Folder variables are not working correctly #632

Franz-Heinz opened this issue May 13, 2022 · 3 comments

Comments

@Franz-Heinz
Copy link

Franz-Heinz commented May 13, 2022

Expected behavior

The use of $root/Installer/GOG/$game and $root/Installer/HumbleBundle/$game for storing the installers should store each game in an own folder.

Actual behavior

Using $root/Installer/GOG/$game and $root/Installer/HumbleBundle/$game for storing the installers does not create game folders for each game but creates a subfolder named '$game'. It seems like '$game' is not recognized as a variable by GameHub

Steps to reproduce

Set $root/Installer/GOG/$game and $root/Installer/HumbleBundle/$game as folders for storing the installers in the GameHub settings. After downloading a game via GameHub check the created folder name.

Version and environment

GameHub 0.16.1-ebb46ff-master
Ubuntu 18.04. LTS (all updates installed)

- GameHub
    Version: 0.16.1-ebb46ff-master
    Branch:  master
    Commit:  ebb46ff0b394fbb004e8a3d2bfc4f47410dec18f
- Environment
    Distro:  Ubuntu 18.04.6 LTS
    DE:      ubuntu:GNOME
    GTK:     3.22.30
@CartoonFan
Copy link

CartoonFan commented May 22, 2022

From what I can see, $game seems to work only in the "Game directory" field; everywhere else, it shows up as a literal $game. But yeah, a fix would feel nice.

EDIT: I made a pull request that hopefully fixes the issue (#635) 🤞

@tkashkin
Copy link
Owner

Should be fixed by 550226e.

@CartoonFan
Copy link

Thanks! I'll give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants