Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Proton > 5.13 not starting #596

Merged
merged 11 commits into from
Dec 4, 2021
Merged

Fix Proton > 5.13 not starting #596

merged 11 commits into from
Dec 4, 2021

Conversation

Lucki
Copy link
Contributor

@Lucki Lucki commented Nov 27, 2021

Logging adjustments

The logging requires SteamGameId to be set.

https://github.com/ValveSoftware/Proton/blob/50b4c8785f389f0840bfc6a9ee3f233c9de2da48/proton#L953-L954 :

if not "SteamGameId" in os.environ:
    return False

Old code for comparison:
https://github.com/ValveSoftware/Proton/blame/f27ab32edb1517fcd79665ced44cad91dedfe36c/proton#L831-L857

I removed the debug flags for performance reasons in this PR.

Syncing calls to wineboot

There's another error coming up in 6.3 which isn't problematic in 5.13:

err:esync:esync_init Failed to open esync shared memory file; make sure no stale wineserver instances are running without WINEESYNC.

This can be worked around by calling waitforexitandrun instead of just run but it would probably be better to solve the problem instead:
With an already running wineserver the sync options have to match with the calls later on by Proton. For now it's hardcoding WINEESYNC and WINEFSYNC to the defaults of Proton.


Fixes #593

@Lucki Lucki marked this pull request as draft November 30, 2021 23:06
@Lucki Lucki marked this pull request as ready for review December 1, 2021 00:01
@tkashkin tkashkin changed the base branch from master to dev December 4, 2021 21:50
@tkashkin tkashkin merged commit 6f9b4ba into tkashkin:dev Dec 4, 2021
@Lucki
Copy link
Contributor Author

Lucki commented Dec 4, 2021

Sorry, forgot about dev :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Game can't be made to run with proton
5 participants