-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Proton > 5.13 not starting #596
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untested
Sorry, forgot about dev :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging adjustments
The logging requires
SteamGameId
to be set.https://github.com/ValveSoftware/Proton/blob/50b4c8785f389f0840bfc6a9ee3f233c9de2da48/proton#L953-L954 :
Old code for comparison:
https://github.com/ValveSoftware/Proton/blame/f27ab32edb1517fcd79665ced44cad91dedfe36c/proton#L831-L857
I removed the debug flags for performance reasons in this PR.
Syncing calls to
wineboot
There's another error coming up in 6.3 which isn't problematic in 5.13:
This can be worked around by calling
waitforexitandrun
instead of justrun
but it would probably be better to solve the problem instead:With an already running wineserver the sync options have to match with the calls later on by Proton. For now it's hardcoding
WINEESYNC
andWINEFSYNC
to the defaults of Proton.Fixes #593