Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ImgBot] Optimize images #2866

Merged
merged 1 commit into from
Apr 29, 2019
Merged

[ImgBot] Optimize images #2866

merged 1 commit into from
Apr 29, 2019

Conversation

VocalFan
Copy link
Contributor

@VocalFan VocalFan commented Apr 4, 2019

/screenshot.png -- 83.75kb -> 50.57kb (39.62%)
Faster loading! Lol.

@CLAassistant
Copy link

CLAassistant commented Apr 4, 2019

CLA assistant check
All committers have signed the CLA.

@VocalFan
Copy link
Contributor Author

VocalFan commented Apr 4, 2019

I signed it but it's pending. I rechecked 3 times.

@sbrl
Copy link
Member

sbrl commented Apr 4, 2019

Hey, thanks for the PR!

While you may have signed, @CLAassistant is probably talking about the email address that your bot has used in the commit.

The GitHub account with the email address in the commit attached to it needs to sign the CLA :-)

@mebeim
Copy link
Member

mebeim commented Apr 20, 2019

Hi, @ghostslayer989, could you please create a single commit done by you (not the bot) or change the author of this commit to yourself, so that the CLA check can pass and we can merge this?

To change the author:

git checkout imgbot
git commit --amend --author="your-name-or-alias <your-github-email>"
git push -f

Be sure to use the same e-mail you used to sign the CLA (probably ghostslayer989@users.noreply.github.com).

Otherwise, I see no alternative except closing this and doing it ourselves.

/screenshot.png -- 83.75kb -> 50.57kb (39.62%)
@mebeim
Copy link
Member

mebeim commented Apr 29, 2019

Alright, I force pushed on your repo to update the commit author. I'm merging this now since it's already accepted.

@mebeim mebeim merged commit 1d4f347 into tldr-pages:master Apr 29, 2019
@bl-ue bl-ue added the documentation Issues/PRs modifying the documentation. label Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues/PRs modifying the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants