Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openscad: add page #6296

Merged
merged 2 commits into from
Aug 5, 2021
Merged

openscad: add page #6296

merged 2 commits into from
Aug 5, 2021

Conversation

pixelcmtd
Copy link
Member

@pixelcmtd pixelcmtd commented Aug 3, 2021 •
edited
Loading

  • The page (if new), does not already exist in the repository.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Closes #6268

einverne
einverne requested changes Aug 4, 2021
View reviewed changes
Copy link
Member

@einverne einverne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the new page, but I left a little suggestion for you to take a look. According to the guideline, when we refer to a file or a directory, we often use the suggestion format.

pages/common/openscad.md Outdated Show resolved Hide resolved
pages/common/openscad.md Outdated Show resolved Hide resolved
pages/common/openscad.md Outdated Show resolved Hide resolved
@mfrw mfrw added the new command Issues requesting creation of a new page. label Aug 4, 2021
@CleanMachine1
Copy link
Member

Closes #6268

mfrw
mfrw approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
Thank you for your contribution.

@mfrw mfrw merged commit e445bc5 into tldr-pages:main Aug 5, 2021
@pixelcmtd pixelcmtd deleted the add-openscad branch August 6, 2021 01:17
@CleanMachine1 CleanMachine1 mentioned this pull request Aug 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CleanMachine1 CleanMachine1 CleanMachine1 left review comments

@einverne einverne einverne approved these changes

@mfrw mfrw mfrw approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

page request: openscad
4 participants
@pixelcmtd @CleanMachine1 @einverne @mfrw