Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glab-auth: add page #7612

Merged
merged 6 commits into from
Feb 5, 2022
Merged

glab-auth: add page #7612

merged 6 commits into from
Feb 5, 2022

Conversation

reinhart1010
Copy link
Collaborator

  • The page (if new), does not already exist in the repository.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Version of the command being documented (if known):

See #7554

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Jan 5, 2022
@reinhart1010 reinhart1010 mentioned this pull request Jan 5, 2022
Closed
7 tasks
mfrw
mfrw reviewed Jan 5, 2022
View reviewed changes
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes :)

pages/common/glab-auth.md Outdated Show resolved Hide resolved
pages/common/glab-auth.md Outdated Show resolved Hide resolved
pages/common/glab-auth.md Outdated Show resolved Hide resolved
pages/common/glab-auth.md Outdated Show resolved Hide resolved
@navarroaxel navarroaxel changed the title glab-auth: Add page glab-auth: add page Jan 5, 2022
@reinhart1010 @mfrw
glab-auth: Apply suggestion from @mfrw
a9dfcdb 
Co-authored-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
navarroaxel
navarroaxel reviewed Jan 8, 2022
View reviewed changes
pages/common/glab-auth.md Outdated Show resolved Hide resolved
pages/common/glab-auth.md Outdated Show resolved Hide resolved
pages/common/glab-auth.md Outdated Show resolved Hide resolved
reinhart1010 and others added 2 commits January 11, 2022 10:17
@reinhart1010 @navarroaxel
Update pages/common/glab-auth.md
26f9ab6 
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@reinhart1010
glab-auth: fix GitLab branding
8a439c0
@navarroaxel navarroaxel requested a review from mfrw January 16, 2022 16:28
mfrw
mfrw approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @reinhart1010

@mfrw mfrw requested a review from navarroaxel January 19, 2022 04:43
navarroaxel
navarroaxel requested changes Jan 19, 2022
View reviewed changes
pages/common/glab-auth.md Outdated Show resolved Hide resolved
pages/common/glab-auth.md Outdated Show resolved Hide resolved
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the waiting Issues/PRs with Pending response by the author. label Feb 5, 2022
@github-actions github-actions bot removed the waiting Issues/PRs with Pending response by the author. label Feb 5, 2022
@navarroaxel navarroaxel merged commit aac892a into tldr-pages:main Feb 5, 2022
@reinhart1010 reinhart1010 deleted the glab-auth branch July 12, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@mfrw mfrw mfrw approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reinhart1010 @navarroaxel @mfrw