Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindkey: add page #8089

Merged
merged 5 commits into from
May 22, 2022
Merged

bindkey: add page #8089

merged 5 commits into from
May 22, 2022

Conversation

Liu233w
Copy link
Contributor

@Liu233w Liu233w commented May 14, 2022

  • The page (if new), does not already exist in the repository.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Version of the command being documented (if known):

zsh 5.8 (x86_64-apple-darwin21.0)

@CLAassistant
Copy link

CLAassistant commented May 14, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label May 14, 2022
@tldr-bot

This comment was marked as resolved.

Sign in to view
@tldr-bot

This comment was marked as resolved.

Sign in to view
@tldr-bot

This comment was marked as resolved.

Sign in to view
@marchersimon marchersimon added the review needed Prioritized PRs marked for reviews from maintainers. label May 14, 2022
mfrw
mfrw reviewed May 18, 2022
View reviewed changes
pages/common/bindkey.md Outdated Show resolved Hide resolved
@Liu233w @mfrw
bindkey: fix typo
14b6a39 
Co-authored-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
navarroaxel
navarroaxel reviewed May 18, 2022
View reviewed changes
pages/common/bindkey.md Outdated Show resolved Hide resolved
pages/common/bindkey.md Outdated Show resolved Hide resolved
pages/common/bindkey.md Outdated Show resolved Hide resolved
Liu233w and others added 3 commits May 19, 2022 14:22
@Liu233w @navarroaxel
bindkey: update document
f6d5484 
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@Liu233w @navarroaxel
bindkey: update document
2896393 
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@Liu233w @navarroaxel
bindkey: fix document
d481fcc 
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
mfrw
mfrw approved these changes May 22, 2022
View reviewed changes
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Thank you for your contribution

@mfrw mfrw merged commit b9919a0 into tldr-pages:main May 22, 2022
@navarroaxel navarroaxel removed the review needed Prioritized PRs marked for reviews from maintainers. label May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@mfrw mfrw mfrw approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Liu233w @CLAassistant @tldr-bot @navarroaxel @mfrw @marchersimon