Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS-related fixes #796

Closed
wants to merge 2 commits into from
Closed

RSS-related fixes #796

wants to merge 2 commits into from

Conversation

maleadt
Copy link

@maleadt maleadt commented Mar 8, 2021

No description provided.

@maleadt
Copy link
Author

maleadt commented Mar 8, 2021

I see you've caught some of these fixes already, I'll remove them here.

@tlienart
Copy link
Owner

tlienart commented Mar 8, 2021

Thanks a lot for this, adding some thoughts for the eventual completion of the work on my side:

  • full content has an ambiguity for {{..}} function in terms of how they should be inserted
  • the description should be plain text if there's content (though actually it looks like no one knows), there's no function to go from markdown to plain text at the moment

@maleadt
Copy link
Author

maleadt commented Mar 8, 2021

FWIW (maybe relevant as part of the bigger picture), I'm also happy to host my own version of an RSS template that suits my needs. With Hugo, it was convenient to do so as the RSS feed was just another template: https://github.com/JuliaGPU/juliagpu.org/blob/ce6a64b1f33e7eb9c9473705e73f1afa7ac7ee65/themes/vanilla-bootstrap/layouts/_default/rss.xml. As it looks like Franklin already has some sort of templating engine for the HTML layout, could that be used for e.g. RSS and sitemap generation too (instead of the custom generators)?

@tlienart
Copy link
Owner

tlienart commented Mar 8, 2021

This is a very good point and I had not thought about it, thanks! I need to mull over this a bit and hopefully something nice will come out 😄

Edit: to keep track, MichaelHatherly/CommonMark.jl#18

@tlienart
Copy link
Owner

tlienart commented Apr 3, 2021

closing this as changes are now pending on #799, thanks Tim

@tlienart tlienart closed this Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants