Removing Update Policy from Build Packs #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raghits
pushed a commit
that referenced
this pull request
Dec 12, 2019
…ing develop to secret-mgmnt (#1243) * Node10 support (#1204) * nodejs10 support * removing duplicate files * removing python2 traces * fixed spell err * c# support for azure functions * consistent use of servicePlatform and domain * More restrictions on service/domain length More restrictions on service/domain length to cater to IAM role naming style with serverless framework * Swap Python for Node.js icon in create service Signed-off-by: PGobz <p.gobin@gmail.com> * Ordering of supported Nodejs runtimes * Fix for GET /services & added new API path - /services/search (#1214) * created new endpoint for search and exact match provided for services list. * test updated. * POST method for /search is removed. * optimized code with conditions * syntax error fixed * Fix Error with Search Filter (#1219) * syntax error fix * test case update * test case update * reverted change * Added search endpoint check, to provide query result by 'search contains' scenario. * JS error fix * Adding custom role for tvault * Removing unused code * Checking for internal access * Changes in build pack api * remove updatePolicy which needs to be as part of install/adding account to the stack. (#1226) * fixing syntax err * Fixes during validation * fixes * fixes * fixes * Fix typo * fixes for jazz core functions * fixes for jazz core functions * fixes for create asset role * fixes for create asset role * Making changes in build -apck api * Making changes in build -apck api * Making changes in build -apck api * Making changes in build -apck api * Hotfix: Setting Default ProviderTimeout for api and function (#1228) * make sure providerTimeout has defaults for api and lambda. * reading defaults from config, always setting it. * Changes in sls-app build pack * Changes in sls-app build pack * Changes in sls-app build pack * Changes in sls-app build pack * fixing issues * Changes in sls-app build pack * Leverage CloudWatch log group tags instead of parsing log group naming convention (#1217) * removed createSubscriptionFilters * changes for retrieving tags from logGroup * changes for retrieving logs from non-primary account * changes to support other build packs * changes ported to splunk * using {functionName} tag in the config packs. * update signature of functionName. * update function signature. * set the providerTimeout. * Renaming safe_details to safe * Renaming safe_details to safe * renaming customEventRole to customRole * fixes for cmnts * fixes for cmnts * Update Authorizers Lambda Function Name (#1232) * remove updatePolicy which needs to be as part of install/adding account to the stack. * update authorizers to use the new convention with _ for function names. * update lambda name. * fixes for cmnts * fixes for cmnts * fixes for cmnts * fixes for cmnts * Fix after validations * Fixing cognito * Fixing cognito * Fix after validations * fixes to kinesis streamers (#1233) * changes for replacing variables with actual values in log streamer function. * Removing safe while deleting a service * handling deletion of safe * handling deletion of safe * fixing issues * fixing issues * fixing issues * fixing issues * fixing issues * fixing issues * fixing issues * fixing issues * fixing issues * fixing issues * fixinng safe creation for website issue * fixinng safe creation for website issue * Removed unwanted vars * sls-app providerTimeout and update function signature (#1235) * remove updatePolicy which needs to be as part of install/adding account to the stack. * update authorizers to use the new convention with _ for function names. * update lambda name. * add providerTimeout for sls-app as well. * remove check for providerTimeout. * ensure trigger function names are consistent. * providerTimeout is expected in config. * ensure provider and function timeout are set. * specify provider timeout for sls-app in serverless-build-rules.yml * fixes. * Region Update for prod, dev and stg endpoints (#1236) * rebased with node10 and including changes * removed createSubscriptionFilters * changes for retrieving tags from * changes as per review comments * changes as per review comments * changes for retrieving logs from non-primary account * changes to support other build packs * changes ported to splunk * changes as per review comments * changes as per review comments * update to log-streamer files as per review comments * changes as per review comments * changes as per review comments * changes as per review comments * changes * using {functionName} tag in the config packs. * make sure function name is consistent and attached to API gateway. also set the providerTimeout. * only set providerTimeout for api and function. * changes for build pack function and api * update signature of functionName. * update function signature. * set the providerTimeout. * changes as per review comments and validated in stack * changes for replacing variables with actual values in log streamer function. * changes * Update Log API (#1237) * remove updatePolicy which needs to be as part of install/adding account to the stack. * update authorizers to use the new convention with _ for function names. * update lambda name. * add providerTimeout for sls-app as well. * remove check for providerTimeout. * ensure trigger function names are consistent. * providerTimeout is expected in config. * ensure provider and function timeout are set. * specify provider timeout for sls-app in serverless-build-rules.yml * fixes. * servicename and domain as separate fields. * authorizer change in t-vault api * Fix typo * removing unwanted code * Bug fix for vault disabled scenario * Bug fix for vault disabled scenario * Bug fix for vault disabled scenario * fix typo * Fix syntax * Fix format * Fix format * fix bug * adding a sleep in onboarding flow * Fix format * bug fix
raghits
added a commit
that referenced
this pull request
Dec 26, 2019
* Node10 support (#1204) * nodejs10 support * removing duplicate files * removing python2 traces * fixed spell err * c# support for azure functions * consistent use of servicePlatform and domain * More restrictions on service/domain length More restrictions on service/domain length to cater to IAM role naming style with serverless framework * Swap Python for Node.js icon in create service Signed-off-by: PGobz <p.gobin@gmail.com> * Ordering of supported Nodejs runtimes * Fix for GET /services & added new API path - /services/search (#1214) * created new endpoint for search and exact match provided for services list. * test updated. * POST method for /search is removed. * optimized code with conditions * syntax error fixed * Fix Error with Search Filter (#1219) * syntax error fix * test case update * test case update * reverted change * Added search endpoint check, to provide query result by 'search contains' scenario. * JS error fix * remove updatePolicy which needs to be as part of install/adding account to the stack. (#1226) * make sure providerTimeout has defaults for api and lambda. * reading defaults from config. always setting it. * Hotfix: Setting Default ProviderTimeout for api and function (#1228) * make sure providerTimeout has defaults for api and lambda. * reading defaults from config, always setting it. * Leverage CloudWatch log group tags instead of parsing log group naming convention (#1217) * removed createSubscriptionFilters * changes for retrieving tags from logGroup * changes for retrieving logs from non-primary account * changes to support other build packs * changes ported to splunk * using {functionName} tag in the config packs. * update signature of functionName. * update function signature. * set the providerTimeout. * Update Authorizers Lambda Function Name (#1232) * remove updatePolicy which needs to be as part of install/adding account to the stack. * update authorizers to use the new convention with _ for function names. * update lambda name. * fixes to kinesis streamers (#1233) * changes for replacing variables with actual values in log streamer function. * sls-app providerTimeout and update function signature (#1235) * remove updatePolicy which needs to be as part of install/adding account to the stack. * update authorizers to use the new convention with _ for function names. * update lambda name. * add providerTimeout for sls-app as well. * remove check for providerTimeout. * ensure trigger function names are consistent. * providerTimeout is expected in config. * ensure provider and function timeout are set. * specify provider timeout for sls-app in serverless-build-rules.yml * fixes. * Region Update for prod, dev and stg endpoints (#1236) * rebased with node10 and including changes * removed createSubscriptionFilters * changes for retrieving tags from * changes as per review comments * changes as per review comments * changes for retrieving logs from non-primary account * changes to support other build packs * changes ported to splunk * changes as per review comments * changes as per review comments * update to log-streamer files as per review comments * changes as per review comments * changes as per review comments * changes as per review comments * changes * using {functionName} tag in the config packs. * make sure function name is consistent and attached to API gateway. also set the providerTimeout. * only set providerTimeout for api and function. * changes for build pack function and api * update signature of functionName. * update function signature. * set the providerTimeout. * changes as per review comments and validated in stack * changes for replacing variables with actual values in log streamer function. * changes * Update Log API (#1237) * remove updatePolicy which needs to be as part of install/adding account to the stack. * update authorizers to use the new convention with _ for function names. * update lambda name. * add providerTimeout for sls-app as well. * remove check for providerTimeout. * ensure trigger function names are consistent. * providerTimeout is expected in config. * ensure provider and function timeout are set. * specify provider timeout for sls-app in serverless-build-rules.yml * fixes. * servicename and domain as separate fields. * Fix typo Co-authored-by: Satish Malireddi <dev.satishm@gmail.com> Co-authored-by: dimple patel <dimplejpatel93@gmail.com> Co-authored-by: SauravD <43289511+SauarvD@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Removes the update policy from all build packs.
Benefits
Policy is not overwritten
Possible Drawbacks
None.
Applicable Issues
Policy is overwritten on each deploy.