Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secret Management tooltip #1240

Merged
merged 2 commits into from
Dec 9, 2019
Merged

Secret Management tooltip #1240

merged 2 commits into from
Dec 9, 2019

Conversation

swati-sh
Copy link
Contributor

@swati-sh swati-sh commented Dec 9, 2019

Description of the Change

  • Included tooltip

raghits
raghits requested changes Dec 9, 2019
View reviewed changes
Copy link
Collaborator

@raghits raghits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

@raghits
Update text.
f49d12b 
Update text.
chimpuz
chimpuz approved these changes Dec 9, 2019
View reviewed changes
Copy link
Collaborator

@chimpuz chimpuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

raghits
raghits approved these changes Dec 9, 2019
View reviewed changes
Copy link
Collaborator

@raghits raghits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@raghits raghits merged commit bc18897 into tmobile:secret-mgmt Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raghits raghits raghits approved these changes

@chimpuz chimpuz chimpuz approved these changes

Assignees

@swati-sh swati-sh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swati-sh @raghits @chimpuz