adding primary key to role tables #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sajeer-nooh
requested changes
Sep 26, 2019
| @@ -752,6 +752,8 @@ CREATE TABLE IF NOT EXISTS `oauth_user_role_mapping` ( | |||
| `modifiedDate` datetime DEFAULT NULL | |||
| ) ENGINE=InnoDB DEFAULT CHARSET=latin1; | |||
|
|
|||
| ALTER TABLE oauth_user_role_mapping ADD PRIMARY KEY (userRoleId); | |||
There was a problem hiding this comment.
@johnrex-j
Before adding primary key, you should delete all the duplicate values because in all previous deployments, there are duplicate data get loaded into the table because of not having a primary key/unique key and this will make problem to the already installed pacbotstack.
See here,
During each deployemnt when this line get executed duplicate entries are created
| @@ -771,6 +773,8 @@ CREATE TABLE IF NOT EXISTS `oauth_user_roles` ( | |||
| `modifiedDate` datetime DEFAULT NULL | |||
| ) ENGINE=InnoDB DEFAULT CHARSET=latin1; | |||
|
|
|||
| ALTER TABLE oauth_user_roles ADD PRIMARY KEY (roleId); | |||
There was a problem hiding this comment.
This kind of DDL makes problem to the successive DB import as it tries to add primary key to an already existing key. So you should create a procedure for this. Please follow the logic already I added here
KanchanaAradhya
pushed a commit
to KanchanaAradhya/pacbot
that referenced
this pull request
Jan 13, 2020
adding primary key to role tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.