Optionally disable shell history suppression #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After finishing this patch and digging through the code, I'm thinking that #46 was in fact a regression. It was made so that non starting-shell-commands wouldn't spam the history, but should have stayed how it was for If that's the case, then this PR can be reduced to the |
| @@ -75,7 +75,7 @@ def cmd(self, cmd, *args, **kwargs): | |||
|
|
|||
| return self.server.cmd(cmd, *args, **kwargs) | |||
|
|
|||
| def send_keys(self, cmd, enter=True): | |||
| def send_keys(self, cmd, enter=True, suppress_history=True): | |||
| """``$ tmux send-keys`` to the pane. | |||
There was a problem hiding this comment.
Docstring here would be nice too (it ends up showing in api docs)
| @@ -85,6 +85,8 @@ def send_keys(self, cmd, enter=True, suppress_history=True): | |||
| :type cmd: str | |||
| :param enter: Send enter after sending the input. | |||
| :type enter: bool | |||
| :param suppress_history: Don't add these keys to the shell history | |||
| :type suppress_history: bool | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #144.
Adds the
suppress_historyoption to override the default shell history suppression, for theworkspace_builderonly. The flag can be set at the session, window, or pane level, and defaults toTrue(the only existing option before this PR).Documentation and examples have been added as well.