Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: give content match a lower score #4499

Merged
merged 2 commits into from
Sep 26, 2023
Merged

fix: give content match a lower score #4499

merged 2 commits into from
Sep 26, 2023

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Sep 25, 2023

@codesandbox
Copy link

codesandbox bot commented Sep 25, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@pengx17 pengx17 temporarily deployed to development September 25, 2023 16:40 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
affine-dev-docs ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2023 2:56am
affine-prod-temp ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2023 2:56am

@pengx17 pengx17 temporarily deployed to development September 25, 2023 16:40 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 25, 2023 16:40 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 25, 2023 16:40 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 25, 2023 16:40 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 25, 2023 16:40 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 25, 2023 16:40 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 25, 2023 16:40 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 25, 2023 16:40 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 25, 2023 16:40 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 25, 2023 16:40 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 25, 2023 16:40 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 25, 2023 16:40 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 25, 2023 16:40 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 25, 2023 16:40 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 25, 2023 16:40 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 25, 2023 16:40 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 25, 2023 16:42 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (672a01b) 72.48% compared to head (50a9c5e) 72.58%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4499      +/-   ##
==========================================
+ Coverage   72.48%   72.58%   +0.09%     
==========================================
  Files         409      409              
  Lines       14163    14170       +7     
  Branches     1418     1418              
==========================================
+ Hits        10266    10285      +19     
+ Misses       3518     3505      -13     
- Partials      379      380       +1     
Flag Coverage Δ
e2e-plugin-test 33.66% <8.33%> (-0.03%) ⬇️
e2etest 58.22% <83.33%> (-0.01%) ⬇️
e2etest-macos-latest-x64 ?
e2etest-ubuntu-latest-x64 42.13% <8.33%> (-0.03%) ⬇️
e2etest-windows-latest-x64 ∅ <ø> (∅)
server-e2etest 53.46% <8.33%> (+0.41%) ⬆️
server-test 76.29% <ø> (ø)
unittest 53.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/cmdk/src/index.tsx 76.20% <100.00%> (-0.29%) ⬇️
apps/core/src/components/pure/cmdk/data.tsx 71.89% <80.00%> (-0.03%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nx-cloud
Copy link

nx-cloud bot commented Sep 25, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 50a9c5e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx affected --target=build --parallel=5

Sent with 💌 from NxCloud.

@pengx17 pengx17 temporarily deployed to development September 25, 2023 16:44 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 25, 2023 16:44 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 25, 2023 16:44 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 26, 2023 02:55 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 26, 2023 02:55 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 26, 2023 02:55 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 26, 2023 02:55 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 26, 2023 02:55 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 26, 2023 02:56 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 26, 2023 02:56 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 26, 2023 02:56 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 26, 2023 02:56 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 26, 2023 02:56 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 26, 2023 02:56 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 26, 2023 02:56 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 26, 2023 02:56 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 26, 2023 02:56 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 26, 2023 02:56 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 26, 2023 02:56 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 26, 2023 02:56 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 26, 2023 02:58 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 26, 2023 02:59 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 26, 2023 02:59 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 26, 2023 02:59 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 26, 2023 03:04 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 26, 2023 03:04 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development September 26, 2023 03:04 — with GitHub Actions Inactive
@pengx17 pengx17 added this pull request to the merge queue Sep 26, 2023
Merged via the queue into master with commit eb728f7 Sep 26, 2023
22 of 23 checks passed
@pengx17 pengx17 deleted the xp/fix/0926/cmdk-sort branch September 26, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants