Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(electron): cleanup secondary db logic #6710

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Apr 26, 2024

No description provided.

Copy link

graphite-app bot commented Apr 26, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Apr 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@pengx17 pengx17 marked this pull request as ready for review April 26, 2024 10:12
Copy link

nx-cloud bot commented Apr 26, 2024

@pengx17 pengx17 requested a review from EYHN April 26, 2024 10:13
@pengx17 pengx17 force-pushed the 04-26-refactor_electron_cleanup_secondary_db_logic branch from 86b756a to 4ed6b8d Compare April 26, 2024 10:29
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 52.94118% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 64.67%. Comparing base (d015be2) to head (5d114ea).

Files Patch % Lines
...end/electron/src/helper/db/workspace-db-adapter.ts 21.05% 13 Missing and 2 partials ⚠️
...kages/frontend/electron/src/helper/db/ensure-db.ts 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6710      +/-   ##
==========================================
- Coverage   64.78%   64.67%   -0.12%     
==========================================
  Files         588      588              
  Lines       27654    27579      -75     
  Branches     2513     2495      -18     
==========================================
- Hits        17917    17837      -80     
- Misses       9452     9464      +12     
+ Partials      285      278       -7     
Flag Coverage Δ
server-test 74.46% <ø> (-0.10%) ⬇️
unittest 41.21% <52.94%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 04-26-refactor_electron_cleanup_secondary_db_logic branch from 4ed6b8d to 19c049d Compare April 26, 2024 10:43
Copy link

graphite-app bot commented Apr 26, 2024

Merge activity

@pengx17 pengx17 force-pushed the 04-26-refactor_electron_cleanup_secondary_db_logic branch from 19c049d to 5d114ea Compare April 26, 2024 10:57
@graphite-app graphite-app bot merged commit 5d114ea into canary Apr 26, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 04-26-refactor_electron_cleanup_secondary_db_logic branch April 26, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants