Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): right sidebar's content is not centered when clientBorder enabled #7034

Merged
merged 1 commit into from
May 23, 2024
Merged

fix(core): right sidebar's content is not centered when clientBorder enabled #7034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(core): right sidebar's content is not centered when clientBorder … 
…enabled (#7034)

- before
    ![CleanShot%202024-05-22%20at%2018.18.15@2x.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/LakojjjzZNf6ogjOVwKE/4fe8f114-6471-4e28-8788-0d50b39efe7a.png)
    ![CleanShot%202024-05-22%20at%2018.27.18@2x.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/LakojjjzZNf6ogjOVwKE/95ff58d7-2f6b-42ae-85f2-6b026ad48c05.png)

- after
    ![CleanShot 2024-05-22 at 19.10.30@2x.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/LakojjjzZNf6ogjOVwKE/920fc348-b53f-4e5e-aa85-3329372923b1.png)
  • Loading branch information
@CatsJuice
CatsJuice committed May 23, 2024
commit d066da3e8a8b7a72c5e1bafb75111d808ac8b5c3
1 change: 0 additions & 1 deletion packages/frontend/core/src/modules/multi-tab-sidebar/view/body.css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ export const root = style({
flex: 1,
width: '100%',
height: '100%',
minWidth: '320px',
overflow: 'hidden',
alignItems: 'center',
borderTop: `1px solid ${cssVar('borderColor')}`,
Expand Down
9 changes: 0 additions & 9 deletions packages/frontend/core/src/modules/right-sidebar/view/container.css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,5 @@ export const sidebarContainer = style({
export const sidebarBodyTarget = style({
flex: 1,
width: '100%',
minWidth: '320px',
overflow: 'hidden',
selectors: {
[`&[data-client-border=true]`]: {
paddingLeft: 9,
},
[`&[data-client-border=false]`]: {
borderLeft: `1px solid ${cssVar('borderColor')}`,
},
},
});
Loading