feat(electron): multi tabs support #7440

pengx17 · 2024-07-07T18:29:19Z

use https://www.electronjs.org/docs/latest/api/web-contents-view to serve different tab views
added tabs view manager in electron to handle multi-view actions and events.

graphite-app · 2024-07-07T18:29:23Z

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

pengx17 · 2024-07-07T18:29:32Z

refactor: tab views meta use GlobalState #7509
feat(electron): multi tabs support #7440 👈
feat(electron): shared storage #7492
refactor(infra): memento use undefined #7491
canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite

nx-cloud · 2024-07-07T18:30:07Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1eb7408. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

codecov · 2024-07-07T18:33:49Z

Codecov Report

Attention: Patch coverage is 8.87372% with 267 lines in your changes missing coverage. Please review.

Project coverage is 56.45%. Comparing base (6bc5337) to head (1eb7408).
Report is 1 commits behind head on canary.

Files	Patch %	Lines
...tabs-header/services/desktop-state-synchronizer.ts	1.31%	75 Missing ⚠️
...s/workbench/services/desktop-state-synchronizer.ts	1.36%	72 Missing ⚠️
.../modules/app-tabs-header/views/app-tabs-header.tsx	6.25%	45 Missing ⚠️
...pp-tabs-header/services/app-tabs-header-service.ts	0.00%	18 Missing ⚠️
...d/core/src/modules/workbench/entities/workbench.ts	0.00%	8 Missing ⚠️
...modules/workbench/services/workbench-view-state.ts	20.00%	8 Missing ⚠️
...core/src/modules/workbench/view/workbench-link.tsx	0.00%	6 Missing ⚠️
...frontend/core/src/components/app-sidebar/index.tsx	0.00%	4 Missing ⚠️
...kages/frontend/core/src/modules/workbench/index.ts	0.00%	4 Missing ⚠️
...es/frontend/core/src/components/page-list/list.tsx	0.00%	3 Missing ⚠️
... and 16 more

Additional details and impacted files

@@            Coverage Diff             @@
##           canary    #7440      +/-   ##
==========================================
- Coverage   57.19%   56.45%   -0.74%     
==========================================
  Files         937      949      +12     
  Lines       41612    42264     +652     
  Branches     4781     4930     +149     
==========================================
+ Hits        23799    23860      +61     
- Misses      17456    18047     +591     
  Partials      357      357

Flag	Coverage Δ
server-test	`78.82% <ø> (+0.07%)`	⬆️
unittest	`27.49% <8.87%> (-0.77%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/common/infra/src/framework/core/index.ts

packages/frontend/component/src/ui/scrollbar/use-has-scroll-top.tsx

packages/frontend/core/src/components/app-tabs/app-tabs.tsx

packages/frontend/web/src/index.tsx

packages/frontend/electron-api/src/index.ts

packages/frontend/core/src/components/root-app-sidebar/index.tsx

packages/frontend/electron/package.json

packages/frontend/electron/src/main/index.ts

packages/frontend/core/src/hooks/use-navigate-helper.ts

forehalo · 2024-07-26T12:09:37Z

packages/frontend/core/src/modules/app-tabs-header/views/app-tabs-header.tsx

+            </button>
+
+            {viewIdx !== workbench.views.length - 1 ? (
+              <div className={styles.splitViewSeparator} />


why not border

forehalo · 2024-07-26T12:43:41Z

packages/frontend/core/src/modules/workbench/entities/workbench.ts

  activeView$ = LiveData.computed(get => {
    const activeIndex = get(this.activeViewIndex$);
    const views = get(this.views$);
-    return views[activeIndex];
+    return views[activeIndex]; // todo: this could be null


if it's hard to fix default active view index to 0, I perfer not persisting it, we can still get all tabs back though

forehalo · 2024-07-26T12:49:58Z

packages/frontend/core/src/pages/workspace/detail-page/detail-page.tsx

@@ -206,18 +206,27 @@ const DetailPageImpl = memo(function DetailPageImpl() {
    [jumpToPageBlock, docCollection.id, openPage, jumpToTag, workspace.id]
  );

+  const [container, setContainer] = useState<HTMLElement | null>(null);


why not useRef

forehalo · 2024-07-26T12:54:27Z

packages/frontend/component/src/ui/scrollbar/use-has-scroll-top.tsx

@@ -20,12 +13,12 @@ export function useHasScrollTop(ref: RefObject<HTMLElement> | null) {
      }
    }

-    container.addEventListener('scroll', updateScrollTop);
+    container?.addEventListener('scroll', updateScrollTop);


forehalo · 2024-07-26T13:03:10Z

packages/frontend/electron/src/main/events.ts

-        subscription();
+        // subscription on quit sometimes crashes the app
+        try {
+          subscription();


unsubscribe

forehalo · 2024-07-26T13:04:37Z

packages/frontend/electron/src/preload/electron-api.ts

-    ?.split('=')[1],
+  windowName:
+    process.argv.find(arg => arg.startsWith('--window-name='))?.split('=')[1] ??
+    'unknown',


maybe ${schema}?

forehalo

cool

github-actions bot added mod:infra Environment related issues and discussions app:electron Related to electron app app:core labels Jul 7, 2024

pengx17 force-pushed the 07-08-feat_electron_multi_tabs_support branch 4 times, most recently from 804b9cb to c5548bd Compare July 10, 2024 09:10

github-actions bot added the mod:dev label Jul 10, 2024

pengx17 force-pushed the 07-08-feat_electron_multi_tabs_support branch 14 times, most recently from 8ad9cfa to 1b5027c Compare July 14, 2024 07:51

pengx17 changed the base branch from canary to eyhn/feat/electron-shared-storage July 14, 2024 07:52

This was referenced Jul 14, 2024

refactor(infra): memento use undefined #7491

Merged

feat(electron): shared storage #7492

Merged

EYHN force-pushed the eyhn/feat/electron-shared-storage branch from 1a8ee68 to 4b622ef Compare July 15, 2024 02:31

pengx17 force-pushed the 07-08-feat_electron_multi_tabs_support branch 6 times, most recently from a91ca88 to 5f97f19 Compare July 26, 2024 07:54

EYHN reviewed Jul 26, 2024

View reviewed changes

packages/common/infra/src/framework/core/index.ts Show resolved Hide resolved

EYHN reviewed Jul 26, 2024

View reviewed changes

packages/frontend/component/src/ui/scrollbar/use-has-scroll-top.tsx Outdated Show resolved Hide resolved

pengx17 force-pushed the 07-08-feat_electron_multi_tabs_support branch 3 times, most recently from 014a765 to 010ad31 Compare July 26, 2024 09:11