Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert back electron to v30 #7453

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Jul 9, 2024

fix AF-1058, fix PD-1410

Copy link

graphite-app bot commented Jul 9, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Jul 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the app:electron Related to electron app label Jul 9, 2024
@pengx17 pengx17 marked this pull request as ready for review July 9, 2024 03:33
Copy link

nx-cloud bot commented Jul 9, 2024

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.48%. Comparing base (de40844) to head (86218d8).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #7453   +/-   ##
=======================================
  Coverage   57.48%   57.48%           
=======================================
  Files         903      903           
  Lines       39804    39804           
  Branches     4488     4488           
=======================================
  Hits        22880    22880           
  Misses      16568    16568           
  Partials      356      356           
Flag Coverage Δ
server-test 78.17% <ø> (ø)
unittest 28.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Jul 9, 2024

Merge activity

@pengx17 pengx17 force-pushed the xp/07-09-chore_revert_back_electron_to_v30 branch from f3e88a9 to 86218d8 Compare July 9, 2024 03:50
@graphite-app graphite-app bot merged commit 86218d8 into canary Jul 9, 2024
32 checks passed
@graphite-app graphite-app bot deleted the xp/07-09-chore_revert_back_electron_to_v30 branch July 9, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants