Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): values in edit not saved when closing info modal #7465

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Jul 10, 2024

Before the modification, when the modal is closed, if a value is being edited, the input's on blur event cannot be triggered to automatically save.

2024-07-10.5.11.25.mov

Copy link

graphite-app bot commented Jul 10, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@JimmFly JimmFly marked this pull request as ready for review July 10, 2024 09:09
Copy link
Member Author

JimmFly commented Jul 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Jul 10, 2024

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.74%. Comparing base (bd02797) to head (e3c3d1a).

Files Patch % Lines
...s/affine/page-properties/info-modal/info-modal.tsx 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7465      +/-   ##
==========================================
+ Coverage   57.69%   57.74%   +0.04%     
==========================================
  Files         907      907              
  Lines       40251    40258       +7     
  Branches     4569     4570       +1     
==========================================
+ Hits        23224    23246      +22     
+ Misses      16675    16660      -15     
  Partials      352      352              
Flag Coverage Δ
server-test 78.56% <ø> (+0.07%) ⬆️
unittest 29.14% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Jul 22, 2024

Merge activity

Before the modification, when the modal is closed, if a value is being edited, the input's on blur event cannot be triggered to automatically save.

https://github.com/toeverything/AFFiNE/assets/102217452/60235cec-0022-4c4d-b213-28f2331a0c5b
@graphite-app graphite-app bot merged commit e3c3d1a into canary Jul 22, 2024
32 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0710/fix branch July 22, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

4 participants