Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add outgoing links to doc info #7955

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Aug 23, 2024

close AF-1270

CleanShot 2024-08-23 at 13 22 38@2x

@JimmFly JimmFly marked this pull request as ready for review August 23, 2024 05:24
Copy link

graphite-app bot commented Aug 23, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

JimmFly commented Aug 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Aug 23, 2024

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 52.79%. Comparing base (3ce92f2) to head (5e8683c).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...s/affine/page-properties/info-modal/info-modal.tsx 0.00% 8 Missing ⚠️
...e/block-suite-editor/bi-directional-link-panel.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7955      +/-   ##
==========================================
- Coverage   52.79%   52.79%   -0.01%     
==========================================
  Files        1207     1207              
  Lines       47807    47811       +4     
  Branches     5810     5811       +1     
==========================================
  Hits        25242    25242              
- Misses      22185    22189       +4     
  Partials      380      380              
Flag Coverage Δ
server-test 77.65% <ø> (ø)
unittest 25.74% <10.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Aug 29, 2024

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants