Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): cancel block not found alert #8310

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Sep 19, 2024

No description provided.

Copy link

graphite-app bot commented Sep 19, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

fundon commented Sep 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Sep 19, 2024

@fundon fundon force-pushed the fundon/09_19_cancel_block_not_found_alert branch 3 times, most recently from 8ef709f to e1cf55b Compare September 19, 2024 08:52
@github-actions github-actions bot added the mod:i18n Related to i18n label Sep 19, 2024
@fundon fundon marked this pull request as ready for review September 19, 2024 08:53
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.72%. Comparing base (1417aca) to head (c47d44f).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8310      +/-   ##
==========================================
+ Coverage   72.64%   72.72%   +0.07%     
==========================================
  Files         519      519              
  Lines       32826    32826              
  Branches     2971     2973       +2     
==========================================
+ Hits        23846    23872      +26     
+ Misses       8949     8923      -26     
  Partials       31       31              
Flag Coverage Δ
server-test 78.87% <ø> (+0.10%) ⬆️
unittest 49.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the fundon/09_19_cancel_block_not_found_alert branch from e1cf55b to 74b36e6 Compare September 19, 2024 09:00
@fundon fundon changed the title chore(core): cancel block not found alert refactor(core): simplify scroll anchoring and remove unused code Sep 19, 2024
@fundon fundon changed the title refactor(core): simplify scroll anchoring and remove unused code refactor(core): cancel block not found alert Sep 19, 2024
@fundon fundon force-pushed the fundon/09_19_cancel_block_not_found_alert branch from 74b36e6 to cefb86a Compare September 19, 2024 09:07
@fundon fundon changed the title refactor(core): cancel block not found alert chore(core): cancel block not found alert Sep 19, 2024
Copy link

graphite-app bot commented Sep 19, 2024

Merge activity

@fundon fundon force-pushed the fundon/09_19_cancel_block_not_found_alert branch from cefb86a to c47d44f Compare September 19, 2024 09:18
@graphite-app graphite-app bot merged commit c47d44f into canary Sep 19, 2024
39 checks passed
@graphite-app graphite-app bot deleted the fundon/09_19_cancel_block_not_found_alert branch September 19, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants