Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): emoji as doc icon support with feature flag #8348

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Sep 23, 2024

close AF-1412

Adjusted the priority of the public doc icon:

  1. block-reference
  2. journal
  3. page reference
  4. emoji (*new)
  5. default

Copy link

graphite-app bot commented Sep 23, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added mod:infra Environment related issues and discussions app:core labels Sep 23, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Sep 23, 2024

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.05%. Comparing base (6e9db76) to head (17fec89).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8348      +/-   ##
==========================================
- Coverage   70.10%   70.05%   -0.06%     
==========================================
  Files         524      524              
  Lines       33068    33068              
  Branches     2904     2904              
==========================================
- Hits        23183    23165      -18     
- Misses       9543     9561      +18     
  Partials      342      342              
Flag Coverage Δ
server-test 76.71% <ø> (-0.07%) ⬇️
unittest 45.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice marked this pull request as ready for review September 23, 2024 02:59
@CatsJuice CatsJuice force-pushed the catsjuice/feat/doc-emoji-icon branch from 978d671 to 2569ba1 Compare October 8, 2024 02:03
Copy link

graphite-app bot commented Oct 10, 2024

Merge activity

EYHN pushed a commit that referenced this pull request Oct 10, 2024
close AF-1412

Adjusted the priority of the public doc icon:

1. block-reference
2. journal
3. page reference
4. **emoji** (*new)
5. default
@EYHN EYHN force-pushed the catsjuice/feat/doc-emoji-icon branch from 2569ba1 to da03a76 Compare October 10, 2024 04:11
close AF-1412

Adjusted the priority of the public doc icon:

1. block-reference
2. journal
3. page reference
4. **emoji** (*new)
5. default
@EYHN EYHN force-pushed the catsjuice/feat/doc-emoji-icon branch from da03a76 to 17fec89 Compare October 10, 2024 04:14
@graphite-app graphite-app bot merged commit 17fec89 into canary Oct 10, 2024
38 checks passed
@graphite-app graphite-app bot deleted the catsjuice/feat/doc-emoji-icon branch October 10, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:infra Environment related issues and discussions
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants