Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove atty dependency since it's not used #530

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

yerke
Copy link
Contributor

@yerke yerke commented Feb 24, 2024

Closes #508

@yerke yerke requested a review from a team as a code owner February 24, 2024 06:14
Copy link
Collaborator

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. But could you please follow this guide to update your commit message and PR title? Thanks!
https://github.com/tokio-rs/console/blob/main/CONTRIBUTING.md#commit-message-guidelines

Remove atty dependency since it's not used any more.

Closes tokio-rs#508
@yerke yerke changed the title Remove atty dependency since it's not used chore: remove atty dependency since it's not used Feb 25, 2024
@yerke
Copy link
Contributor Author

yerke commented Feb 25, 2024

Thanks for taking a look, @hi-rustin. Done.

@Rustin170506
Copy link
Collaborator

Thanks! 💚 💙 💜 💛 ❤️

@Rustin170506 Rustin170506 merged commit bdaf05e into tokio-rs:main Feb 26, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2021-0145: Potential unaligned read
3 participants