Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make log an optional dependency #1673

Merged
merged 1 commit into from
May 27, 2023
Merged

make log an optional dependency #1673

merged 1 commit into from
May 27, 2023

Conversation

carllerche
Copy link
Member

Currently, Mio depends on log. In rust-lang/log#552, the log maintainers aim to increase log's MSRV to 1.60. This MSRV increase would impact Mio, which in turn, would impact Tokio. As of 1.25, Tokio supports Rust 1.49 with the intent of supporting it until March 2024.

This commit makes log an optional dependency for those who wish to maintain a lower MSRV.

Currently, Mio depends on `log`. In rust-lang/log#552, the `log`
maintainers aim to increase `log`'s MSRV to 1.60. This MSRV increase
would impact Mio, which in turn, would impact Tokio. As of 1.25, Tokio
supports Rust 1.49 with the intent of supporting it until March 2024.

This commit makes `log` an optional dependency for those who wish to
maintain a lower MSRV.
@carllerche
Copy link
Member Author

I don't think the CI failures are related.

@Thomasdezeeuw
Copy link
Collaborator

I'll send a pr to fix the CI.

@Thomasdezeeuw
Copy link
Collaborator

Thomasdezeeuw commented May 27, 2023

@carllerche are there any Tokio versions still supported that use v0.7? If so we'll have to backport this.

@Darksonn
Copy link
Contributor

No, the earliest LTS that is still supported is the 1.18.x series, and we upgraded to mio v0.8 in the 1.17.0 release (link).

@Thomasdezeeuw
Copy link
Collaborator

CI should be fixed by #1674, so I'm merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants