Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial solution for windows mio problem #776 #868

Closed
wants to merge 6 commits into from
Closed

Initial solution for windows mio problem #776 #868

wants to merge 6 commits into from

Conversation

PerfectLaugh
Copy link
Contributor

Refer to issue #776
I don't know if it is elegant. But passed all tests in network section.
(Somehow I couldn't pass the a timer all the time, even with vanilla version)

@PerfectLaugh PerfectLaugh changed the title Initial solution for windows mio problem? Idk... Initial solution for windows mio problem Aug 19, 2018
@PerfectLaugh PerfectLaugh changed the title Initial solution for windows mio problem Initial solution for windows mio problem #776 Aug 20, 2018
@hawkw
Copy link
Member

hawkw commented Aug 20, 2018

It looks like you've run rustfmt on all the code in the project, not just the code added in this branch. That means that this diff appears to change a lot of code unrelated to your PR --- can we back that change out?

@PerfectLaugh
Copy link
Contributor Author

oh sorry

@PerfectLaugh
Copy link
Contributor Author

I thought it would not be pushed into this pull request

@PerfectLaugh
Copy link
Contributor Author

but I will have to revisit what I've done here first

@PerfectLaugh
Copy link
Contributor Author

Anyone can review it?

@carllerche
Copy link
Member

Thanks for the PR. It is very intense and I will need to schedule a good chunk of time to review.

@PerfectLaugh PerfectLaugh mentioned this pull request Apr 20, 2019
Open
@Thomasdezeeuw Thomasdezeeuw added this to the v0.7 milestone Jun 17, 2019
@PerfectLaugh
Copy link
Contributor Author

Invalidate this Pull request for better improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7-alpha
Development

Successfully merging this pull request may close these issues.
4 participants
@PerfectLaugh @hawkw @carllerche @Thomasdezeeuw