Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test combinations of task behavior #3967

Merged
merged 16 commits into from
Jul 22, 2021
Merged

Test combinations of task behavior #3967

merged 16 commits into from
Jul 22, 2021

Conversation

Darksonn
Copy link
Contributor

No description provided.

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime M-task Module: tokio/task labels Jul 19, 2021
@Darksonn
Copy link
Contributor Author

The loom test did not work with the threaded scheduler because panics could leak from one thread to another due to its use of generators to switch between threads. However, the loom test was useful as it caught memory leaks. Changing it to a miri test retains the leak test as miri will also catch leaks.

I also run it as a normal test. I only run the threaded scheduler in the normal test and not in miri.

@Darksonn Darksonn mentioned this pull request Jul 21, 2021
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches.

@Darksonn Darksonn merged commit ced7992 into master Jul 22, 2021
@Darksonn Darksonn deleted the test-combinations branch July 22, 2021 07:06
sthagen added a commit to sthagen/tokio-rs-tokio that referenced this pull request Jul 22, 2021
runtime: add large test and fix leak it found (tokio-rs#3967)
@Darksonn Darksonn mentioned this pull request Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime M-task Module: tokio/task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants