rt(threaded): move inject queue lock to worker #5754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a step towards the ongoing effort to unify the mutex in the multi-threaded scheduler. The Inject queue is split into two structs. `Shared` holds fields that are concurrently accessed, and `Synced` holds fields that must be locked to access. The multi-threaded scheduler is responsible for locking `Synced` and passing it in when needed. The commit also splits `inject` into multiple files to help reduce the amount of code defined in macros.
carllerche
added
C-maintenance
Noah-Kennedy
approved these changes
Jun 2, 2023
Darksonn
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a step towards the ongoing effort to unify the mutex in the multi-threaded scheduler. The Inject queue is split into two structs.
Sharedholds fields that are concurrently accessed, andSyncedholds fields that must be locked to access. The multi-threaded scheduler is responsible for lockingSyncedand passing it in when needed.The commit also splits
injectinto multiple files to help reduce the amount of code defined in macros.