Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rt(alt): fix memory leak and increase max preemption when running Loom CI tests #5911

Merged
merged 7 commits into from
Aug 10, 2023

Conversation

carllerche
Copy link
Member

@carllerche carllerche commented Aug 4, 2023

The memory leak was caused by a bug during shutdown where some state was leaked.

I'm not 100% sure why the loom tests are faster now, but I would guess it is because I removed debug assertion that used atomics (which would also increase the state space to explore).

@carllerche carllerche added A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime A-ci Area: The continuous integration setup R-loom-multi-thread-alt Run loom multi-thread alt tests on this PR labels Aug 4, 2023
@github-actions github-actions bot removed the R-loom-multi-thread-alt Run loom multi-thread alt tests on this PR label Aug 4, 2023
@github-actions github-actions bot added the R-loom-multi-thread-alt Run loom multi-thread alt tests on this PR label Aug 7, 2023
@carllerche carllerche marked this pull request as ready for review August 9, 2023 18:23
@carllerche carllerche changed the title rt(alt): experiment with loom CI rt(alt): fix memory leak and increase max preemption when running Loom CI tests Aug 9, 2023
@carllerche carllerche merged commit dd23f08 into master Aug 10, 2023
75 checks passed
@carllerche carllerche deleted the rt-alt-experiment-loom branch August 10, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: The continuous integration setup A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime R-loom-multi-thread-alt Run loom multi-thread alt tests on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants