Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apple tvos support #6045

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

lcruz99
Copy link
Contributor

@lcruz99 lcruz99 commented Oct 3, 2023

This PR allows using tokio lib to target tier 3 *-apple builds:

  • Apple tvOS on aarch64
  • Apple tvOS Simulator on x86_64

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-net Module: tokio/net labels Oct 3, 2023
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Would you be able to add a cargo check for this target to CI?

tokio/src/lib.rs Outdated
@@ -393,6 +393,7 @@
//! * Android (API level 21)
//! * macOS
//! * iOS
//! * tvOS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not going to add a tier 3 target to this list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rereading it I realize now I shouldn't have touched that, sorry about that.

Thanks. Would you be able to add a cargo check for this target to CI?

Sure, I think so, will add.

Copy link
Contributor Author

@lcruz99 lcruz99 Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check my last commit where I add the CI job, however this target requires "appropriate versions of Xcode and the SDKs for tvOS (AppleTVOS.sdk) and/or the tvOS Simulator (AppleTVSimulator.sdk) to build a toolchain and target these platforms." As the runner is a x86_64 machine, it cannot build for this target.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can't add CI, then that's okay. Have you tested that the code works on a real setup?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, so far so good! :)

@lcruz99 lcruz99 force-pushed the add_apple_tvos_support branch 6 times, most recently from bda87a3 to 96da98f Compare October 4, 2023 14:27
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn merged commit 52b29b3 into tokio-rs:master Oct 4, 2023
69 checks passed
@lcruz99 lcruz99 deleted the add_apple_tvos_support branch October 10, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-net Module: tokio/net
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants