core: add support for boxed Collect objects
#1371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds `impl Collect for Box<dyn Collect + Send + Sync + 'static>` which can make it easier to work with collectors that have a type that is hard to name. That tends to happen when building collectors that have been composed with lots of layers and you want to return them from functions or take them as arguments. Using a trait object makes that easier.
davidpdrsn
commented
Apr 26, 2021
| fn current_span(&self) -> span::Current { | ||
| (&**self).current_span() | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm not quite sure if downcast_raw should also be delegated. What do you think?
|
See also #1358 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
impl Collect for Box<dyn Collect + Send + Sync + 'static>which can make it easier to work with collectors that have a type that
is hard to name.
That tends to happen when building collectors that have been composed
with lots of layers and you want to return them from functions or take
them as arguments. Using a trait object makes that easier.