Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subscriber: clear enabled filter map when short circuiting #1575

Merged
merged 5 commits into from
Sep 19, 2021
Merged

subscriber: clear enabled filter map when short circuiting #1575

merged 5 commits into from
Sep 19, 2021

Conversation

hawkw
Copy link
Member

@hawkw hawkw commented Sep 17, 2021

This is essentially the same change as #1569, but for enabled states
rather than register_callsite. When a global filter returns false
from enabled, ensure that the per-layer filter FilterMap and debug
counters are cleared, so that they are empty on the next enabled call.

See #1563

@hawkw hawkw requested a review from a team as a code owner September 17, 2021 17:25
@hawkw
subscriber: clear enabled filter map when short circuiting
1202a86 
This is essentially the same change as #1569, but for `enabled` states
rather than `register_callsite`. When a global filter returns `false`
from `enabled`, ensure that the per-layer filter `FilterMap` and debug
counters are cleared, so that they are empty on the next `enabled` call.

See #1563
@hawkw hawkw mentioned this pull request Sep 17, 2021
Closed
@hawkw hawkw merged commit b09b368 into v0.1.x Sep 19, 2021
@hawkw hawkw deleted the eliza/fix-enabled-panic branch September 19, 2021 19:37
hawkw added a commit that referenced this pull request Sep 19, 2021
@hawkw
subscriber: prepare to release 0.2.24
8f65176 
# 0.2.24 (September 19, 2021)

This release contains a number of bug fixes, including a fix for
`tracing-subscriber` failing to compile on the minimum supported Rust
version of 1.42.0. It also adds `IntoIterator` implementations for the
`Targets` type.

### Fixed

- Fixed compilation on Rust 1.42.0 ([#1580], [#1581])
- **registry**: Ensure per-layer filter `enabled` state is cleared when
  a global filter short-circuits filter evaluation ([#1575])
- **layer**: Fixed `Layer::on_layer` not being called for `Box`ed
  `Layer`s, which broke  per-layer filtering ([#1576])

### Added

- **filter**: Added `Targets::iter`, returning an iterator over the set
  of target-level pairs enabled by a `Targets` filter ([#1574])
- **filter**:  Added `IntoIterator` implementations for `Targets` and
  `&Targets` ([#1574])

Thanks to new contributor @connec for contributing to this release!

[#1580]: #1580
[#1581]: #1581
[#1575]: #1575
[#1576]: #1576
[#1574]: #1574
@hawkw hawkw mentioned this pull request Sep 19, 2021
Merged
hawkw added a commit that referenced this pull request Sep 20, 2021
@hawkw
subscriber: prepare to release 0.2.24 (#1582)
9ac27fb 
# 0.2.24 (September 19, 2021)

This release contains a number of bug fixes, including a fix for
`tracing-subscriber` failing to compile on the minimum supported Rust
version of 1.42.0. It also adds `IntoIterator` implementations for the
`Targets` type.

### Fixed

- Fixed compilation on Rust 1.42.0 ([#1580], [#1581])
- **registry**: Ensure per-layer filter `enabled` state is cleared when
  a global filter short-circuits filter evaluation ([#1575])
- **layer**: Fixed `Layer::on_layer` not being called for `Box`ed
  `Layer`s, which broke  per-layer filtering ([#1576])

### Added

- **filter**: Added `Targets::iter`, returning an iterator over the set
  of target-level pairs enabled by a `Targets` filter ([#1574])
- **filter**:  Added `IntoIterator` implementations for `Targets` and
  `&Targets` ([#1574])

Thanks to new contributor @connec for contributing to this release!

[#1580]: #1580
[#1581]: #1581
[#1575]: #1575
[#1576]: #1576
[#1574]: #1574
davidbarsky pushed a commit that referenced this pull request Nov 29, 2021
@hawkw @davidbarsky
subscriber: clear enabled filter map when short circuiting (#1575)
320a0f4 
This is essentially the same change as #1569, but for `enabled` states
rather than `register_callsite`. When a global filter returns `false`
from `enabled`, ensure that the per-layer filter `FilterMap` and debug
counters are cleared, so that they are empty on the next `enabled` call.

See #1563
davidbarsky pushed a commit that referenced this pull request Mar 18, 2022
@hawkw @davidbarsky
subscriber: clear enabled filter map when short circuiting (#1575)
4a25297 
This is essentially the same change as #1569, but for `enabled` states
rather than `register_callsite`. When a global filter returns `false`
from `enabled`, ensure that the per-layer filter `FilterMap` and debug
counters are cleared, so that they are empty on the next `enabled` call.

See #1563
hawkw added a commit that referenced this pull request Mar 23, 2022
@hawkw
subscriber: clear enabled filter map when short circuiting (#1575)
0428412 
This is essentially the same change as #1569, but for `enabled` states
rather than `register_callsite`. When a global filter returns `false`
from `enabled`, ensure that the per-layer filter `FilterMap` and debug
counters are cleared, so that they are empty on the next `enabled` call.

See #1563
hawkw added a commit that referenced this pull request Mar 23, 2022
@hawkw
subscriber: clear enabled filter map when short circuiting (#1575)
667d365 
This is essentially the same change as #1569, but for `enabled` states
rather than `register_callsite`. When a global filter returns `false`
from `enabled`, ensure that the per-subscriber filter `FilterMap` and
debug counters are cleared, so that they are empty on the next `enabled`
call.

See #1563
hawkw added a commit that referenced this pull request Mar 23, 2022
@hawkw
subscriber: clear enabled filter map when short circuiting (#1575)
db72031 
This is essentially the same change as #1569, but for `enabled` states
rather than `register_callsite`. When a global filter returns `false`
from `enabled`, ensure that the per-subscriber filter `FilterMap` and
debug counters are cleared, so that they are empty on the next `enabled`
call.

See #1563
hawkw added a commit that referenced this pull request Mar 24, 2022
@hawkw
subscriber: clear enabled filter map when short circuiting (#1575)
8e6f0ed 
This is essentially the same change as #1569, but for `enabled` states
rather than `register_callsite`. When a global filter returns `false`
from `enabled`, ensure that the per-subscriber filter `FilterMap` and
debug counters are cleared, so that they are empty on the next `enabled`
call.

See #1563
hawkw added a commit that referenced this pull request Mar 24, 2022
@hawkw
subscriber: clear enabled filter map when short circuiting (#1575)
9c39495 
This is essentially the same change as #1569, but for `enabled` states
rather than `register_callsite`. When a global filter returns `false`
from `enabled`, ensure that the per-subscriber filter `FilterMap` and
debug counters are cleared, so that they are empty on the next `enabled`
call.

See #1563
hawkw added a commit that referenced this pull request Mar 24, 2022
@hawkw
subscriber: clear enabled filter map when short circuiting (#1575)
fa53463 
This is essentially the same change as #1569, but for `enabled` states
rather than `register_callsite`. When a global filter returns `false`
from `enabled`, ensure that the per-subscriber filter `FilterMap` and
debug counters are cleared, so that they are empty on the next `enabled`
call.

See #1563
hawkw added a commit that referenced this pull request Mar 24, 2022
@hawkw
subscriber: clear enabled filter map when short circuiting (#1575)
a572fe4 
This is essentially the same change as #1569, but for `enabled` states
rather than `register_callsite`. When a global filter returns `false`
from `enabled`, ensure that the per-subscriber filter `FilterMap` and
debug counters are cleared, so that they are empty on the next `enabled`
call.

See #1563
hawkw added a commit that referenced this pull request Mar 24, 2022
@hawkw
subscriber: clear enabled filter map when short circuiting (#1575)
de067c7 
This is essentially the same change as #1569, but for `enabled` states
rather than `register_callsite`. When a global filter returns `false`
from `enabled`, ensure that the per-subscriber filter `FilterMap` and
debug counters are cleared, so that they are empty on the next `enabled`
call.

See #1563
hawkw added a commit that referenced this pull request Mar 24, 2022
@hawkw
subscriber: clear enabled filter map when short circuiting (#1575)
5593680 
This is essentially the same change as #1569, but for `enabled` states
rather than `register_callsite`. When a global filter returns `false`
from `enabled`, ensure that the per-subscriber filter `FilterMap` and
debug counters are cleared, so that they are empty on the next `enabled`
call.

See #1563
hawkw added a commit that referenced this pull request Mar 24, 2022
@hawkw
subscriber: clear enabled filter map when short circuiting (#1575)
b9f4468 
This is essentially the same change as #1569, but for `enabled` states
rather than `register_callsite`. When a global filter returns `false`
from `enabled`, ensure that the per-subscriber filter `FilterMap` and
debug counters are cleared, so that they are empty on the next `enabled`
call.

See #1563
hawkw added a commit that referenced this pull request Mar 24, 2022
@hawkw
subscriber: clear enabled filter map when short circuiting (#1575)
6a4d2f2 
This is essentially the same change as #1569, but for `enabled` states
rather than `register_callsite`. When a global filter returns `false`
from `enabled`, ensure that the per-subscriber filter `FilterMap` and
debug counters are cleared, so that they are empty on the next `enabled`
call.

See #1563
@davidbarsky davidbarsky mentioned this pull request Sep 26, 2023
Merged
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
@hawkw @kaffarell
subscriber: clear enabled filter map when short circuiting (tokio-r…
ba1c36b 
…s#1575)

This is essentially the same change as tokio-rs#1569, but for `enabled` states
rather than `register_callsite`. When a global filter returns `false`
from `enabled`, ensure that the per-layer filter `FilterMap` and debug
counters are cleared, so that they are empty on the next `enabled` call.

See tokio-rs#1563
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
@hawkw @kaffarell
subscriber: prepare to release 0.2.24 (tokio-rs#1582)
d1c1b5f 
# 0.2.24 (September 19, 2021)

This release contains a number of bug fixes, including a fix for
`tracing-subscriber` failing to compile on the minimum supported Rust
version of 1.42.0. It also adds `IntoIterator` implementations for the
`Targets` type.

### Fixed

- Fixed compilation on Rust 1.42.0 ([tokio-rs#1580], [tokio-rs#1581])
- **registry**: Ensure per-layer filter `enabled` state is cleared when
  a global filter short-circuits filter evaluation ([tokio-rs#1575])
- **layer**: Fixed `Layer::on_layer` not being called for `Box`ed
  `Layer`s, which broke  per-layer filtering ([tokio-rs#1576])

### Added

- **filter**: Added `Targets::iter`, returning an iterator over the set
  of target-level pairs enabled by a `Targets` filter ([tokio-rs#1574])
- **filter**:  Added `IntoIterator` implementations for `Targets` and
  `&Targets` ([tokio-rs#1574])

Thanks to new contributor @connec for contributing to this release!

[tokio-rs#1580]: tokio-rs#1580
[tokio-rs#1581]: tokio-rs#1581
[tokio-rs#1575]: tokio-rs#1575
[tokio-rs#1576]: tokio-rs#1576
[tokio-rs#1574]: tokio-rs#1574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hawkw