Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscriber: fix leading comma with Pretty formatter #1833

Merged
merged 1 commit into from
Jan 13, 2022

Commits on Jan 13, 2022

  1. subscriber: fix leading comma with Pretty formatter

    PR #1661 introduced a regression with the `Pretty` formatter: the
    `PrettyVisitor` type was [accidentally changed][1] from being
    constructed with `is_empty: true` to being constructed with `is_empty:
    false` This means that when visiting a set of span fields, we emit a
    leading `, ` _before_ the first field, which looks quite bad.
    
    This branch changes it back, and now the output looks nice again. :)
    
    [1]: 937c5d7#diff-a27a4c3564a0c2f1b7af32be0f9eec25ddfbe8b4c2be8d74e84d874b919b393bR227
    hawkw committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    abb0a79 View commit details
    Browse the repository at this point in the history