Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better documentation & tests for using Level constants for #[instrument(level = X)] #2350

Merged
merged 7 commits into from
Oct 27, 2022

Commits on Oct 17, 2022

  1. Configuration menu
    Copy the full SHA
    1604f89 View commit details
    Browse the repository at this point in the history
  2. Change examples to use Level constants

    I think it's preferable to use the named constants rather than string
    literals for levels since it makes it easier to see what the options are
    and catch typos in a more normal way.
    
    Also document that the `level` parameter can be named constant, string
    literal or numeric constant.
    jsgf committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    8e0def4 View commit details
    Browse the repository at this point in the history
  3. Fix review issues

    The doc references to `Level` don't resolve because `tracing-attribute`
    doesn't have a direct dependency on `tracing` - not sure how to resolve
    right now.
    jsgf committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    592fd57 View commit details
    Browse the repository at this point in the history
  4. Make tracing-attribute depend on tracing-core just for doc references

    I hope there's a better way to deal with this.
    jsgf committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    267455b View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2022

  1. Fix nightly warnings

    jsgf committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    cc9cb7f View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. fixup docs

    davidbarsky committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    4f9585b View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. doc fix fix

    jsgf committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    5bbab29 View commit details
    Browse the repository at this point in the history