Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracing-attributes: allow warning clippy unreachable #2356

Merged
merged 3 commits into from
Nov 4, 2022
Merged

tracing-attributes: allow warning clippy unreachable #2356

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02e07cc
tracing-attributes: allow warning clippy unreachable (#2270)
Abhicodes-crypto Oct 25, 2022
58ca16e
Merge branch 'master' into clippy-warning
davidbarsky Nov 3, 2022
ea5d4d6
Merge branch 'master' into clippy-warning
hawkw Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tracing-attributes/src/expand.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ pub(crate) fn gen_function<'a, B: ToTokens + 'a>(
// unreachable, but does affect inference, so it needs to be written
// exactly that way for it to do its magic.
let fake_return_edge = quote_spanned! {return_span=>
#[allow(unreachable_code, clippy::diverging_sub_expression, clippy::let_unit_value)]
#[allow(unreachable_code, clippy::diverging_sub_expression, clippy::let_unit_value, clippy::unreachable)]
if false {
let __tracing_attr_fake_return: #return_type =
unreachable!("this is just for type inference, and is unreachable code");
Expand Down