Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.1.x: clean up warnings #3069

Merged
merged 3 commits into from
Sep 24, 2024
Merged

v0.1.x: clean up warnings #3069

merged 3 commits into from
Sep 24, 2024

Conversation

djc
Copy link
Contributor

@djc djc commented Aug 29, 2024

Motivation

Trying to clean up the proliferation of warnings seen with rustc 1.80 (and --all-features).

(Best reviewed per commit.)

@djc djc requested review from hawkw and a team as code owners August 29, 2024 09:13
@djc djc changed the title V0.1.x custom cfg v0.1.x: clean up warnings Aug 29, 2024
@@ -144,12 +144,6 @@ use crate::stdlib::{
error,
};

#[cfg(feature = "alloc")]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no alloc features defined in this crate right now.

@@ -1,12 +1,8 @@
#[cfg(feature = "futures-01")]
mod futures_01;

#[cfg(feature = "futures_preview")]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There doesn't appear to be defined feature for futures_preview.

tracing-subscriber/src/fmt/writer.rs Show resolved Hide resolved
@@ -70,33 +70,8 @@ where
}
}

#[cfg(feature = "tower-util")]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no feature defined for tower-util.

Copy link
Contributor

@kaffarell kaffarell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixes all the clippy/fmt errors I got (except the comment obviously).

tracing-subscriber/src/fmt/writer.rs Show resolved Hide resolved
@djc
Copy link
Contributor Author

djc commented Sep 13, 2024

@hawkw so do you want to approve this? (I technically seem to have merge privileges, not sure if you want me to use them.)

@djc djc force-pushed the v0.1.x-custom-cfg branch 3 times, most recently from 6e64256 to 4956112 Compare September 16, 2024 11:03
Copy link
Contributor

@kaffarell kaffarell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidbarsky davidbarsky enabled auto-merge (squash) September 24, 2024 20:26
Copy link
Member

@davidbarsky davidbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; would be good to have these on master as well.

@davidbarsky davidbarsky merged commit 70a8678 into v0.1.x Sep 24, 2024
52 checks passed
@davidbarsky davidbarsky deleted the v0.1.x-custom-cfg branch September 24, 2024 20:27
@djc
Copy link
Contributor Author

djc commented Sep 24, 2024

What's the state of master these days? Feels like keeping master for 0.2.x is a little counterproductive if the pace towards actually releasing 0.2.x is low.

davidbarsky added a commit that referenced this pull request Oct 1, 2024
@kaffarell
Copy link
Contributor

What's the state of master these days? Feels like keeping master for 0.2.x is a little counterproductive if the pace towards actually releasing 0.2.x is low.

I agree. IMO either we try to release 0.2.x soonish, or we reverse the roles and have 0.1.x -> master and master -> 0.2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants