-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rmkit] patch genie to fix crash in testing #304
Conversation
I'll update tomorrow and check. Should any repeated gesture for any command cause a crash or only the default config? |
any gesture for any command (it's a timing thing), but its easy to use the 3 finger tap rapidly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on rM1 and rM2, works well. Looks good to me!
I can't create a crash with this patch. |
new packages: [ddvk-hacks] Add ddvk-hacks (toltec-dev#247) updated packages: [wireguard][1.0.20210219] - Updated package (and include wireguard-tools) (toltec-dev#285) [rm2fb] update rm2fb to work with xochitl 2.6 (v1.0.1) (toltec-dev#301) [recrossable] Update recrossable (toltec-dev#312) [wikipedia] Initial wikipedia package. [appmarkable] Update appmarkable to 0.0.0-9 and rmservewacominput to 0.3.0-1 (toltec-dev#308) with rm2 support [rmkit] patch genie to fix crash in testing (toltec-dev#304) [oxide] Update Oxide to v2.1.2 (toltec-dev#241) [rm2fb] update rm2fb with wait ioctl and no-op on rM1 (toltec-dev#298) [rmkit] add bufshot app, add lamp, add iago, add changelog (toltec-dev#276) [rmkit] update rmkit to latest (2021-02-17) (toltec-dev#286) [zshelf][0.3.1] - Updated Package (toltec-dev#287) tooling: Pin the Ubuntu version used in workflows to 20.04 (toltec-dev#316) Provide better version number error messages (toltec-dev#314) util.auto_extract: Extract broken symlinks and missing directories (toltec-dev#302) change web background color to #fcfaf8 (toltec-dev#280) Implement build-time package dependencies (toltec-dev#274) Rewrite repo-build-web in Python (toltec-dev#266) Print last 50 lines of output on build error (toltec-dev#263) Hardcode REMOTE_HTTP secret in PR workflows (toltec-dev#262) Rewrite repo-build and package-build in Python (toltec-dev#218) Make bootstrap execution conditional on hash verification (toltec-dev#257) Add Toltec web home page (toltec-dev#193)
New packages: * bufshot - 0.1.0-2 (#276) * ddvk-hacks - 17.04-1 (#247) * iago - 0.1.0-1 (#276) * lamp - 0.1.0-1 (#276) * libdlib, libdlib-dev - 19.21-1 (#274) * libvncserver, libvncserver-dev - 0.9.13-1 (#274) * wikipedia - 0.1.0-2 (#311) Updated packages: * appmarkable - 0.0.0-9 (#308) * decay - 2.1.2~1 (#241) * erode - 2.1.2~1 (#241) * fret - 2.1.2~1 (#241) * genie - 0.1.4-2 (#304) * harmony - 0.1.2-1 (#286) * mines - 0.1.2-1 (#286) * nao - 0.1.2-1 (#286) * oxide - 2.1.2~1 (#241) * recrossable - 0.0.0-5 (#274, #312) * remux - 0.1.8-1 (#286) * rm2fb - 1.0.1-1 (#298, #301) * rmservewacominput - 0.3.0-1 (#308) * rot - 2.1.2~1 (#241) * simple - 0.1.3-1 (#286) * tarnish - 2.1.2~1 (#241) * vnsee - 0.3.1-2 (#274) Tooling: * Pin the Ubuntu version used in workflows to 20.04 (#316) * Provide better version number error messages (#314) * util.auto_extract: Extract broken symlinks and missing directories (#302) * change web background color to #fcfaf8 (#280) * Implement build-time package dependencies (#274) * Rewrite repo-build-web in Python (#266) * Print last 50 lines of output on build error (#263) * Hardcode REMOTE_HTTP secret in PR workflows (#262) * Rewrite repo-build and package-build in Python (#218) * Make bootstrap execution conditional on hash verification (#257) * Add Toltec web home page (#193) Co-authored-by: okay <okay@arkose> Co-authored-by: Mattéo Delabre <spam@delab.re>
Co-authored-by: okay <okay@chalk>
This reverts commit d420eed.
from discussion with matteo, there is a crash in genie on testing (see test plan) when using the example genie config. i tested this patch and verified it fixes the crash.
test plan: