Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rMscreens #571

Merged
merged 16 commits into from
Aug 15, 2023
Merged

rMscreens #571

merged 16 commits into from
Aug 15, 2023

Conversation

pr0fsmith
Copy link

@pr0fsmith pr0fsmith commented Mar 15, 2022

rMscreens is a commandline utility that allows you to easily change your rM screen (sleep screen, power off screen etc). It can also be used to backup and restore your original screens easily.

I wrote this code myself and tested it on the rM2 software version 2.12 https://github.com/pr0fsmith/rMscreens/blob/main/changescrn

@Eeems Eeems changed the base branch from stable to testing March 15, 2022 01:22
@Eeems
Copy link
Member

Eeems commented Mar 18, 2022

I would really recommend adding help output to the script.

I don't think we can merge this until pr0fsmith/rMscreens#2 is resolved though.

Copy link
Member

@Eeems Eeems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move backup location off of root partition

@matteodelabre matteodelabre added the packages Add or improve packages of the repository label Apr 19, 2022
@Eeems
Copy link
Member

Eeems commented Jul 6, 2022

@pr0fsmith did you have a chance to address the requested changes?

@pr0fsmith
Copy link
Author

@pr0fsmith did you have a chance to address the requested changes?

I will do that today.

@pr0fsmith
Copy link
Author

@Eeems All changes have been made.

@Eeems
Copy link
Member

Eeems commented Jul 6, 2022

@pr0fsmith I don't see any changes to this PR? Did you intend to update the source and sha256sum in the package file to pull in the latest changes?

@pr0fsmith
Copy link
Author

@pr0fsmith I don't see any changes to this PR? Did you intend to update the source and sha256sum in the package file to pull in the latest changes?

@Eeems I actually didn't make any changes. It seems as though I made the changes months ago so the existing source should be fine.

@Eeems
Copy link
Member

Eeems commented Jul 6, 2022

@pr0fsmith it looks like this is still pointing at an old commit and doesn't have the changes that were requested.

@Eeems
Copy link
Member

Eeems commented Sep 26, 2022

@pr0fsmith poke

@pr0fsmith
Copy link
Author

pr0fsmith commented Sep 26, 2022 via email

package/rmscreens/package Outdated Show resolved Hide resolved
@Eeems
Copy link
Member

Eeems commented Sep 26, 2022

@pr0fsmith I've added a comment showing what needs to be changed. There is a button to directly apply the suggested changes.

Updates to your repository don't automatically show up here as we point at specific commits so that we know that the source doesn't change between builds. Whenever you update your repository you need to point the recipie at the new commit.

Co-authored-by: Nathaniel van Diepen <Eeems@users.noreply.github.com>
@pr0fsmith
Copy link
Author

I don't understand how to change the recipe. You did it for me last time.

@Eeems
Copy link
Member

Eeems commented Sep 26, 2022

I don't understand how to change the recipe. You did it for me last time.

If you go to the files changed tab, you'll see the recipie there. It's the package/rmscreens/package file.

@Eeems
Copy link
Member

Eeems commented Oct 1, 2022

@pr0fsmith I can't get this to work, there is no help output. When looking at the comment in the script saying how to use it, that doesn't work. It looks like your argument parsing has a loop where it will never work as both -c and -n expect the other setting to already be set.
image

@matteodelabre matteodelabre linked an issue Nov 21, 2022 that may be closed by this pull request
@Eeems
Copy link
Member

Eeems commented May 8, 2023

@pr0fsmith any chance you could get this cleaned up and ready? I'd love to get it merged.

@Eeems Eeems self-requested a review August 15, 2023 17:46
@Eeems Eeems added this to the 2023-W31 merge window milestone Aug 15, 2023
@Eeems
Copy link
Member

Eeems commented Aug 15, 2023

It would be nice to have this automatically do a backup/restore on install, but we'd need a better mechanism to make sure that normal usage can't interfere with what files are backed up or restored.

@Eeems Eeems merged commit 728e57b into toltec-dev:testing Aug 15, 2023
3 checks passed
Eeems added a commit that referenced this pull request Aug 18, 2023
* Add changescrn package

---------

Co-authored-by: Nathaniel van Diepen <Eeems@users.noreply.github.com>
Eeems added a commit that referenced this pull request Aug 23, 2023
### New Packages
- `reterm` - 0230628.1927-1 (#703)
- `sill` - 0.1.1-alpha (#719)
- `changescrn` - 1.0.0-1 (#571)

### Updated Packages
- `yaft` - 0.0.8-2 (#715 #716)
  - Update to 0.0.8
  - Depend on `terminfo`
  - Add patch to start bash as a login shell
- `toltec-base` - 1.2-2 (#715)
  - Adds `/opt/etc/profile` to `/etc/profile.d` so that it automatically loads the environment variables provided by the entware source
- `linux-mainline` - 6.2.0-1 (#657)

### Tooling
- Update build process to use Python 3.10 (#684)
- Added issue templates to the repository (#711)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Add or improve packages of the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rmscreens package
3 participants