Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rust nigthly to build sill #14

Closed
wants to merge 3 commits into from
Closed

Conversation

Etn40ff
Copy link

@Etn40ff Etn40ff commented Oct 29, 2022

No description provided.

Copy link
Member

@LinusCDE LinusCDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for overlooking this. Just got to update plato after a while and also had an issue building due to outdated rust (toltec-dev/toltec#669).

Added a suggestion to update to the current date. In future we should probably pin nightlies to a specific date which is possible, but not guaranteed a given date has all the required components.

For now this should suffice. In order to publish the newest plato, I'll also need this merged. @matteodelabre mind checking/approving this and publishing a new version with this included (e.g. tag v2.3.1)?

rust/Dockerfile Outdated Show resolved Hide resolved
@LinusCDE
Copy link
Member

LinusCDE commented Mar 8, 2023

Also not sure if the build error is just because it's a PR or some kind of deprecation regarding the use of docker login. I suppose it's the first but just wanted to note it.

https://github.com/Etn40ff/toolchain/actions/runs/4367584204/jobs/7639086007:

Error: Cannot perform an interactive login from a non TTY device

@Eeems
Copy link
Member

Eeems commented May 16, 2023

I just opened up a new PR and it's not encountering this error. It might be fixed? Could you try pushing a new empty commit or something similar to trigger a new build?

Bump again as requested
@Eeems
Copy link
Member

Eeems commented Jun 8, 2023

Huh, that's odd. My PR built fine. Maybe it's something to do with my PR being a branch on this repo and not a fork.

@Eeems
Copy link
Member

Eeems commented Jun 8, 2023

I've opened #19 which worked. I'll close this and merge that.

@Eeems Eeems closed this Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants