Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete rule IDs in Flake8 parser #46

Closed
IvanAnishchuk opened this issue Oct 5, 2018 · 2 comments
Closed

Incomplete rule IDs in Flake8 parser #46

IvanAnishchuk opened this issue Oct 5, 2018 · 2 comments

Comments

@IvanAnishchuk
Copy link

IvanAnishchuk commented Oct 5, 2018

Flake8 parser only reports numerical part of rule ids (e.g. PyLint correctly reports all letters and digits and even rule names as it should). Example:

Reporter: Flake8
Rule: 265
Severity: ERROR
File: src/aim/init.py L5
block comment should start with '# '

Reporter: Flake8
Rule: 302
Severity: ERROR
File: src/aim/init.py L6
expected 2 blank lines, found 0
src/aim/__init__.py:5:1: E265 block comment should start with '# '
src/aim/__init__.py:6:1: E302 expected 2 blank lines, found 0

As you can see E265 becomes just 265. Those leading letters are sometimes extremely relevant (they are usually different for different tools flake8 wraps). Can someone please fix it or at least point me to where I should look (though I'm not very experienced with java this is probably simple enough).

@IvanAnishchuk
Copy link
Author

I suspect one could simply tweak the regexp here but, again, I'd rather have some direction because this lib is new to me and I don't wanna break something.

@tomasbjerre
Copy link
Owner

Released now. Open issue again if not working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants